From: Simon Wilkinson <sxw@your-file-system.com>
Date: Tue, 19 Feb 2013 16:15:29 +0000 (+0000)
Subject: ubik: Don't leak memory if mutex init fails
X-Git-Tag: openafs-stable-1_8_0pre1~1466
X-Git-Url: https://git.openafs.org/?p=openafs.git;a=commitdiff_plain;h=58529bd8b055dc1afc567d0cb7749841ce2897d5;hp=b92fbc217c80af7554bbf6dc34de720da8f01c5c

ubik: Don't leak memory if mutex init fails

If we can't initialise the ubik_client mutex, don't leak the
structure when returning an error.

Caught by clang-analyzer

Change-Id: Ib36d2ddf585a31b628e56dce1f33ee859fc835bc
Reviewed-on: http://gerrit.openafs.org/9182
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/ubik/ubikclient.c b/src/ubik/ubikclient.c
index d8747cb..f39ba1e 100644
--- a/src/ubik/ubikclient.c
+++ b/src/ubik/ubikclient.c
@@ -228,6 +228,7 @@ ubik_ClientInit(struct rx_connection **serverconns,
     memset((void *)tc, 0, sizeof(*tc));
 #ifdef AFS_PTHREAD_ENV
     if (pthread_mutex_init(&(tc->cm), (const pthread_mutexattr_t *)0)) {
+	free(tc);
 	return UMUTEXINIT;
     }
 #endif