From: Simon Wilkinson <sxw@your-file-system.com>
Date: Fri, 22 Feb 2013 09:51:24 +0000 (+0000)
Subject: kauth: Don't ignore GetExtendedCellInfo failures
X-Git-Tag: openafs-stable-1_8_0pre1~1468
X-Git-Url: https://git.openafs.org/?p=openafs.git;a=commitdiff_plain;h=5cefa0247fe4f22f769e366a207fb177ee8fb94f

kauth: Don't ignore GetExtendedCellInfo failures

Don't ignore a failure from afsconf_GetExtendedCellInfo, as it will
leave buffers that we later read uninitialised.

Caught by clang-analyzer

Change-Id: Ia0c2675a3083385d011fd340f36bf13373f89feb
Reviewed-on: http://gerrit.openafs.org/9180
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/kauth/kaserver.c b/src/kauth/kaserver.c
index 108bfa9..2fca96a 100644
--- a/src/kauth/kaserver.c
+++ b/src/kauth/kaserver.c
@@ -328,9 +328,13 @@ main(int argc, char *argv[])
 	    "Migrating to a Kerberos 5 KDC is advised.  "
 	    "http://www.openafs.org/no-more-des.html\n"));
 
-    code =
-	afsconf_GetExtendedCellInfo(KA_conf, cell, AFSCONF_KAUTHSERVICE,
-				    &cellinfo, clones);
+    code = afsconf_GetExtendedCellInfo(KA_conf, cell, AFSCONF_KAUTHSERVICE,
+				       &cellinfo, clones);
+    if (code) {
+	afs_com_err(whoami, code, "Couldn't read cell configuration");
+	exit(1);
+    }
+
     if (servers) {
 	if ((code = ubik_ParseServerList(argc, argv, &myHost, serverList))) {
 	    afs_com_err(whoami, code, "Couldn't parse server list");