From: Simon Wilkinson <sxw@your-file-system.com>
Date: Tue, 19 Feb 2013 15:09:41 +0000 (+0000)
Subject: kauth: Remove unused lclpw structure from klog
X-Git-Tag: openafs-stable-1_8_0pre1~1505
X-Git-Url: https://git.openafs.org/?p=openafs.git;a=commitdiff_plain;h=68ce3aa814a7e3085242e705f013f05ed5da2d5c

kauth: Remove unused lclpw structure from klog

klog assigns into, but never references, the lclpw structure. Just
remove it.

Caught by clang-analyzer

Change-Id: I8e94f97ee3ee6cb15193ad80dd9aef39e6f8490b
Reviewed-on: http://gerrit.openafs.org/9170
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/kauth/klog.c b/src/kauth/klog.c
index 3c273ad..ea15360 100644
--- a/src/kauth/klog.c
+++ b/src/kauth/klog.c
@@ -158,7 +158,6 @@ CommandProc(struct cmd_syndesc *as, void *arock)
 
     struct passwd pwent;
     struct passwd *pw = &pwent;
-    struct passwd *lclpw = &pwent;
     char passwd[BUFSIZ];
 
     static char rn[] = "klog";	/*Routine name */
@@ -269,7 +268,6 @@ CommandProc(struct cmd_syndesc *as, void *arock)
 	    foundExplicitCell = 1;
 	    strncpy(realm, cell, sizeof(realm));
 	}
-	lclpw->pw_name = name;
     } else {
 	/* No explicit name provided: use Unix uid. */
 	pw = getpwuid(getuid());
@@ -282,7 +280,6 @@ CommandProc(struct cmd_syndesc *as, void *arock)
 	    }
 	    KLOGEXIT(KABADARGUMENT);
 	}
-	lclpw = pw;
     }
 
     if (as->parms[aPASSWORD].items) {