From: Simon Wilkinson <sxw@your-file-system.com>
Date: Sat, 2 Mar 2013 09:01:59 +0000 (+0000)
Subject: vlserver: Use correct literal in bounds check
X-Git-Tag: openafs-stable-1_8_0pre1~1358
X-Git-Url: https://git.openafs.org/?p=openafs.git;a=commitdiff_plain;h=6a54bf735871d93bc77e5cf166e506f4f2423d0a

vlserver: Use correct literal in bounds check

The base array has VL_MAX_ADDREXTBLKS elements. Use this when
checking for an array overflow, rather than VL_ADDREXTBLK_SIZE.

Caught by coverity (#985600)

Change-Id: Ie60ad5cc79c41245028887871759776549694426
Reviewed-on: http://gerrit.openafs.org/9346
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/vlserver/cnvldb.c b/src/vlserver/cnvldb.c
index 6fdc56f..f31d31c 100644
--- a/src/vlserver/cnvldb.c
+++ b/src/vlserver/cnvldb.c
@@ -535,7 +535,7 @@ convert_mhentries(int oldfd, int newfd, struct vlheader_2 *header,
 		basei = (addr >> 16) & 0xff;
 		index = addr & 0xffff;
 
-		if ((basei >= VL_ADDREXTBLK_SIZE) || !base[basei]) {
+		if ((basei >= VL_MAX_ADDREXTBLKS) || !base[basei]) {
 		    fprintf(stderr,
 			    "Warning: mh entry %d has no IP address; ignored!!\n",
 			    i);