From: Jeffrey Altman <jaltman@your-file-system.com>
Date: Fri, 24 Dec 2010 15:06:05 +0000 (-0500)
Subject: vos: free ubulkentries with xdr_free
X-Git-Tag: openafs-devel-1_7_1~1077
X-Git-Url: https://git.openafs.org/?p=openafs.git;a=commitdiff_plain;h=a7836dda8c1aab18c937c7e8909d4d9a678a53fa;hp=9f17cef3d3614d79b3ab2dc6807f9d0f928ab6db

vos: free ubulkentries with xdr_free

Instead of using free() to free the ubulkentries data structure
use xdr_free().

Change-Id: I367e984d1777fcc8a3ec81b501174fae2fd0c8ff
Reviewed-on: http://gerrit.openafs.org/3590
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
---

diff --git a/src/volser/vos.c b/src/volser/vos.c
index 62501ff..d40e2e9 100644
--- a/src/volser/vos.c
+++ b/src/volser/vos.c
@@ -4430,8 +4430,8 @@ DeleteEntry(struct cmd_syndesc *as, void *arock)
     fprintf(STDOUT,
 	    "Total VLDB entries deleted: %lu; failed to delete: %lu\n",
 	    (unsigned long)totalBack, (unsigned long)totalFail);
-    if (arrayEntries.ubulkentries_val)
-	free(arrayEntries.ubulkentries_val);
+
+    xdr_free((xdrproc_t) xdr_ubulkentries, &arrayEntries);
     return 0;
 }
 
@@ -4626,10 +4626,7 @@ ListVLDB(struct cmd_syndesc *as, void *arock)
 	}
 
 	/* Free the bulk array */
-	if (arrayEntries.ubulkentries_val) {
-	    free(arrayEntries.ubulkentries_val);
-	    arrayEntries.ubulkentries_val = 0;
-	}
+        xdr_free((xdrproc_t) xdr_ubulkentries, &arrayEntries);
     }
 
     /* Here is where we now sort all the entries and print them */
@@ -4981,8 +4978,7 @@ BackSys(struct cmd_syndesc *as, void *arock)
     fprintf(STDOUT, "Total volumes backed up: %lu; failed to backup: %lu\n",
 	    (unsigned long)totalBack, (unsigned long)totalFail);
     fflush(STDOUT);
-    if (arrayEntries.ubulkentries_val)
-	free(arrayEntries.ubulkentries_val);
+    xdr_free((xdrproc_t) xdr_ubulkentries, &arrayEntries);
     return 0;
 }
 
@@ -5083,8 +5079,7 @@ UnlockVLDB(struct cmd_syndesc *as, void *arock)
 	}
     }
 
-    if (arrayEntries.ubulkentries_val)
-	free(arrayEntries.ubulkentries_val);
+    xdr_free((xdrproc_t) xdr_ubulkentries, &arrayEntries);
     return 0;
 }