From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Thu, 7 Feb 2008 21:20:02 +0000 (+0000)
Subject: windows-scache-refcount-race-20080207
X-Git-Tag: BP-openafs-windows-kdfs-ifs~128
X-Git-Url: https://git.openafs.org/?p=openafs.git;a=commitdiff_plain;h=bb2dc54732c865f37b0e9c5b928c850daa795b4d

windows-scache-refcount-race-20080207

LICENSE MIT

if we are going to call a NoLock function better be holding the lock
---

diff --git a/src/WINNT/afsd/cm_callback.c b/src/WINNT/afsd/cm_callback.c
index 4cea28c..6c4b447 100644
--- a/src/WINNT/afsd/cm_callback.c
+++ b/src/WINNT/afsd/cm_callback.c
@@ -1928,8 +1928,8 @@ void cm_CheckCBExpiration(void)
                 lock_ReleaseMutex(&scp->mx);
                 cm_CallbackNotifyChange(scp);
 
-                cm_ReleaseSCacheNoLock(scp);
                 lock_ObtainWrite(&cm_scacheLock);
+                cm_ReleaseSCacheNoLock(scp);
             }
         }
     }