From: Derrick Brashear <shadow@dementia.org>
Date: Tue, 1 Jun 2010 16:08:57 +0000 (-0400)
Subject: rx setpeermtu should handle a host correctly
X-Git-Tag: openafs-devel-1_5_75~202
X-Git-Url: https://git.openafs.org/?p=openafs.git;a=commitdiff_plain;h=ca2bce169e1742e25846ea516e6796de6ac6a282

rx setpeermtu should handle a host correctly

right now, when no port is passed, we don't correctly tweak
the mtu for all peers on a host. do that here.

Change-Id: Ia07f592bf001415d8a76bd3326f2dc6aa0641809
Reviewed-on: http://gerrit.openafs.org/2067
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
---

diff --git a/src/rx/rx.c b/src/rx/rx.c
index 3d9cb7e..0acc80d 100644
--- a/src/rx/rx.c
+++ b/src/rx/rx.c
@@ -2453,28 +2453,31 @@ rxi_Free(void *addr, size_t size)
 void 
 rxi_SetPeerMtu(afs_uint32 host, afs_uint32 port, int mtu)
 {
-    struct rx_peer **peer_ptr, **peer_end;
-    struct rx_peer *peer = NULL;
+    struct rx_peer **peer_ptr = NULL, **peer_end = NULL;
+    struct rx_peer *peer = NULL, *next = NULL;
     int hashIndex;
 
     MUTEX_ENTER(&rx_peerHashTable_lock);
     if (port == 0) {
-       for (peer_ptr = &rx_peerHashTable[0], peer_end =
-                &rx_peerHashTable[rx_hashTableSize]; peer_ptr < peer_end;
-            peer_ptr++) {
-           struct rx_peer *next;
-           for (peer = *peer_ptr; peer; peer = next) {
-               next = peer->next;
-               if (host == peer->host)
-                   break;
-           }
-       }
+	peer_ptr = &rx_peerHashTable[0];
+	peer_end = &rx_peerHashTable[rx_hashTableSize];
+	next = NULL;
+    resume:
+	for ( ; peer_ptr < peer_end; peer_ptr++) {
+	    if (!peer)
+		peer = *peer_ptr;
+	    for ( ; peer; peer = next) {
+		next = peer->next;
+		if (host == peer->host)
+		    break;
+	    }
+	}
     } else {
-       hashIndex = PEER_HASH(host, port);
-       for (peer = rx_peerHashTable[hashIndex]; peer; peer = peer->next) {
-           if ((peer->host == host) && (peer->port == port))
-               break;
-       }
+	hashIndex = PEER_HASH(host, port);
+	for (peer = rx_peerHashTable[hashIndex]; peer; peer = peer->next) {
+	    if ((peer->host == host) && (peer->port == port))
+		break;
+	}
     }
 
     if (peer) {
@@ -2482,12 +2485,19 @@ rxi_SetPeerMtu(afs_uint32 host, afs_uint32 port, int mtu)
         MUTEX_EXIT(&rx_peerHashTable_lock);
 
         MUTEX_ENTER(&peer->peer_lock);
+	/* We don't handle dropping below min, so don't */
+	mtu = MAX(mtu, RX_MIN_PACKET_SIZE);
         peer->ifMTU=MIN(mtu, peer->ifMTU);
         peer->natMTU = rxi_AdjustIfMTU(peer->ifMTU);
         MUTEX_EXIT(&peer->peer_lock);
 
         MUTEX_ENTER(&rx_peerHashTable_lock);
-        peer->refCount++;
+        peer->refCount--;
+        if (!port) {
+            peer = next;
+	    /* pick up where we left off */
+            goto resume;
+        }
     }
     MUTEX_EXIT(&rx_peerHashTable_lock);
 }