From: Simon Wilkinson <sxw@your-file-system.com>
Date: Tue, 19 Feb 2013 14:48:59 +0000 (+0000)
Subject: vol: nuke() doesn't need to zero code
X-Git-Tag: openafs-stable-1_8_0pre1~1511
X-Git-Url: https://git.openafs.org/?p=openafs.git;a=commitdiff_plain;h=d7e7f18887ab8cd4b4539aaf978a7d98a9b38a27

vol: nuke() doesn't need to zero code

We don't need to zero the result code two lines before we assign
a new value to it - just remove the pointless assignment

Caught by clang-analyzer

Change-Id: I8fefdc839ef9980d7f7703add3b11b089d524d38
Reviewed-on: http://gerrit.openafs.org/9167
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/vol/nuke.c b/src/vol/nuke.c
index 3399de5..7679c50 100644
--- a/src/vol/nuke.c
+++ b/src/vol/nuke.c
@@ -190,7 +190,7 @@ nuke(char *aname, VolumeId avolid)
 	    li = ti;
 	}
 	if (li) free(li);
-	code = 0;		/* we really don't care about it except for debugging */
+
 	allInodes = NULL;
 
 	/* at this point, we should try to remove the volume header file itself.