From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Wed, 15 Jul 2009 05:46:45 +0000 (-0400)
Subject: Do not call principal_hton() to copy ktc_principal structs
X-Git-Tag: openafs-devel-1_5_61~111
X-Git-Url: https://git.openafs.org/?p=openafs.git;a=commitdiff_plain;h=f498c18a6f7300eb89ca3b9d9b85c4d461fa8474;hp=a8cd0240e19301673598544166dab639f8e83c10

Do not call principal_hton() to copy ktc_principal structs

Reported by Marcus Watts.

principal_hton() is used to copy butc_principal structs.
Passing in a ktc_principal as source and destination will
result in beyond the end of the ktc_principal.

LICENSE IPL10

Reviewed-on: http://gerrit.openafs.org/86
Verified-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Russ Allbery <rra@stanford.edu>
---

diff --git a/src/budb/procs.c b/src/budb/procs.c
index 7f5f350..f8d37cc 100644
--- a/src/budb/procs.c
+++ b/src/budb/procs.c
@@ -1484,7 +1484,7 @@ CreateDump(struct rx_call *call, struct budb_dumpEntry *dump)
 	dump->created = dump->id;
     d.created = htonl(dump->created);
 
-    principal_hton(&principal, &d.dumper);
+    principal = d.dumper;
     tapeSet_hton(&dump->tapes, &d.tapes);
 
     d.flags = htonl(dump->flags | BUDB_DUMP_INPROGRESS);