Asanka Herath [Wed, 12 Aug 2009 17:57:11 +0000]
rand_s isn't supported on older Visual C compilers
We still support building on Visual Studio 2003 where rand_s() is
not available. If we are building on a Visual C compiler prior
to version 15.00, failover to srand()/rand() instead of using
rand_s().
Reviewed-on: http://gerrit.openafs.org/306
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Felix Frank [Thu, 2 Jul 2009 09:12:24 +0000]
Remove CacheStoreProcs and CacheFetchProcs from the afs_cacheOps.
The entries are no longer used, as the macros from afs_chunkops.h
are no longer necessary and afs_StoreAllSegments calls the
CacheStoreProc proper.
Reviewed-on: http://gerrit.openafs.org/110
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Claudio Bisegni [Wed, 12 Aug 2009 10:41:42 +0000]
OSX AFSBackgrounder fix minor bug
Has been fixed the status menu icon width, now i keeped from icon image.
Fixed the status item icon view redraw.
Reviewed-on: http://gerrit.openafs.org/305
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Jeffrey Altman [Tue, 11 Aug 2009 14:37:19 +0000]
Windows: Dfs Referrals Processing. Not all errors are errors.
When processing a Dfs Referral request, not all lookup errors
should be treated as if the path does not exist. Servers being
down or busy, volumes offline, cell vldb servers not found, etc.
do not mean that the client should go searching elsewhere to
evaluate the path.
LICENSE MIT
Reviewed-on: http://gerrit.openafs.org/304
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Jeffrey Altman [Tue, 11 Aug 2009 12:43:53 +0000]
Windows: Avoid unnecessary DNS lookups
Windows will attempt to open connections to a broad
range of pipe service (share) names which do not contain
a dot in them. Attempts to search for these names as
cell names in DNS result in timeouts and sluggish behavior
when browsing \\AFS in the Explorer Shell.
To avoid this problem, do not perform a DNS lookup for a
cellname that doesn't not contain a dot in it.
LICENSE MIT
Reviewed-on: http://gerrit.openafs.org/302
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Jeffrey Altman [Tue, 11 Aug 2009 12:59:39 +0000]
Windows: Setting Server Preferences
The Windows cache manager can apply administrator specified
server preferences as specified in the registry. When these
rankings are applied the CM_SERVERFLAG_PREF_SET flag was not
set on the cm_server_t object. In addition, appropriate locking
was not being used in the places where the flag was set.
LICENSE MIT
Reviewed-on: http://gerrit.openafs.org/303
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Felix Frank [Thu, 2 Jul 2009 07:14:13 +0000]
Unite CacheFetchProcs and add abstraction calls.
The cache type specific differencies among afs_MemCacheFetchProc
and afs_UFSCacheFetchProc are divided into two sets of "fetchOps".
Upon rxfs_fetchInit, the appropriate set is chosen.
Reviewed-on: http://gerrit.openafs.org/109
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Asanka Herath [Fri, 7 Aug 2009 02:56:42 +0000]
Windows: Implement SRVSVC and WKSSVC RPC interfaces
Windows uses RPC over SMB to communicate with file servers for
administrative tasks including enumeration and queries of file
server shares. This patch implements support for RPC over SMB
and partially implements the SRVSVC and WKSSVC RPC interfaces.
LICENSE MIT
Reviewed-on: http://gerrit.openafs.org/301
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Andrew Deason [Mon, 10 Aug 2009 17:06:26 +0000]
Restore util des dependency
Commit
c3c8a3e2f912855addc2c430f909bdce912e3670 removed 'des' as a
dependency of the 'util' target, but util still depends on des since
rxkstats.c includes des.h. So, put the des dep back in.
Reviewed-on: http://gerrit.openafs.org/278
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
matt@linuxbox.com [Sat, 25 Jul 2009 18:10:25 +0000]
MCAS changes from Matt
Change static max allocators to 30. Add atomic add/sub macros returning
original value, based on CASIO. Add interfaces to add and remove generic
allocator caches. Add atomic inc/dec/sub macros using MCAS primitives.
Add inline assembly for x86_64 and shim for Solaris (9+) atomic operations,
providing Solaris x86 and alternate shim for Solaris Sparc. Set interface
adapted for iteration and generalized for use with opaque key, value
pointers. File cas_skip_func.c provides kv interface, cas_skip_adt.c
provides kv interface, plus iteration on skip lists. Casual dependencies
on stdio and exit() defined out.
LICENSE BSD
Reviewed-on: http://gerrit.openafs.org/214
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Derrick Brashear [Mon, 3 Aug 2009 16:17:14 +0000]
fileserver should actually retry VL_RegisterAddrs on failure
currently the background daemon logic for retrying was never triggered.
easy enough fix: set FS_registered to 1 so the loop retries
Reviewed-on: http://gerrit.openafs.org/266
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Jeffrey Altman [Sun, 2 Aug 2009 22:59:51 +0000]
add xdr_alloc
applications can allocate memory that must be deallocated by
the XDR package. Add xdr_alloc to permit that.
Export from libafsrpc.
LICENSE BSD
Reviewed-on: http://gerrit.openafs.org/269
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Jeffrey Altman [Sat, 1 Aug 2009 16:31:36 +0000]
Make Windows pioctl prototypes consistent with Unix
The Windows pioctl prototypes differed from those now exported
by sys/sys_prototypes.h. This produced undesirable warnings.
LICENSE MIT
Reviewed-on: http://gerrit.openafs.org/260
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Jeffrey Altman [Thu, 6 Aug 2009 03:25:42 +0000]
Windows: Preserve GetLastError during WinTorture testing
When an error occurs during the WinTorture scripts the
actual error was not always being preserved because
subsequent Win32 calls were executed before the value
was logged.
In at least one case, the variable used to store the
last error was not initialized nor assigned in all data
paths.
LICENSE MIT
Reviewed-on: http://gerrit.openafs.org/270
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Marc Dionne [Mon, 27 Jul 2009 18:24:15 +0000]
kauth warning reduction
Warning removal for various functions that manipulates keys and use
several data types interchangeably.
Inline helpers are introduced to convert between the types and are
used when making function calls to target the appropriate type:
des_prototypes.h
cblockptr_to_cblock: des_cblock * to des_cblock
charptr_to_cblock: char * to des_cblock
charptr_to_cblockptr: char * to des_cblock *
rxkad_prototypes.h
ktc_to_cblock: struct ktc_encryptionKey * to des_cblock
ktc_to_cblockptr: struct ktc_encryptionKey * to des_cblock *
kauth_internal.h
EncryptionKey_to_cblock: EncryptionKey * to des_cblock
EncryptionKey_to_ktc: EncryptionKey * to struct ktc_encryptionKey *
ktc_to_EncryptionKey: struct ktc_encryptionKey * to EncryptionKey *
- parameters are adjusted for tkt_DecodeTicket(5), replacing the char *
key with struct ktc_encryptionKey, to match usage
- the get_key function is changed to have a void * parameter, to match
usage
- rxkad_prototypes.h includes des.h to get the des_cblock definition.
This causes conflicts for a few files where the kerberos headers are
also included - aklog/aklog_main.c and WINNT/afsd/afskfw.c
Use NO_DES_H_INCLUDE in thoses cases to skip the new parts of
rxkad_prototypes.h
Reviewed-on: http://gerrit.openafs.org/234
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Claudio Bisegni [Mon, 3 Aug 2009 17:05:46 +0000]
Removed user perspectivev3 file in xcode project and update the gitconfig
gitconfig in src/platform/DARWIN/AFSPreference has been modified to ignore the perspectivev3 that is created by xcode for window layout.Has been also delete the file created for the user
Reviewed-on: http://gerrit.openafs.org/267
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Claudio Bisegni [Mon, 3 Aug 2009 14:40:05 +0000]
Cleaned most warning OSX OpenAFS preference and completed the AFSBackgrounder implementation
At startup the preference pane check for the presence in ~/Library/LaunchAgents of the file it.infn.lnf.network.AFSBackgrounder.plist that. The agent could be started in OpenAFS preference pane view.
AFSBackgrounder has replaced the NSMenuExtra, when it doesn't quit well launchd restart it. AFSBackgrounder can be used also for other work, for now, at login it check the user preference for get token.
Has been made some refactoring in code for remove most warning.
The unused think are been delete from project.
Reviewed-on: http://gerrit.openafs.org/263
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Felix Frank [Thu, 2 Jul 2009 07:02:50 +0000]
Storeops beautifications.
Things can be made a lot more readable in storeOps than in the
monolithic StoreProc.
Also shorten a panic message that is a bit gratuitous.
Reviewed-on: http://gerrit.openafs.org/108
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Claudio Bisegni [Sat, 1 Aug 2009 17:43:39 +0000]
AFS Backgrounder implementation & warirng clean
Replaced the NSMenuExtra and created the AFSBackgrounder that will do all work for aklog at login and manage the Status menu in menu bar
Reviewed-on: http://gerrit.openafs.org/262
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Claudio Bisegni [Wed, 29 Jul 2009 13:12:13 +0000]
Start coding OSX Backgrounder Application, for OpenAFS Preference Pane, that user NSStatusItem
To prevent future compatibility with osx we must use NSStatusItem instead NSMenuExtra that is not documented api.
For this has been created a background only application that will manage all function managed by current NSMenuExtra
Reviewed-on: http://gerrit.openafs.org/261
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Jeffrey Altman [Sat, 1 Aug 2009 15:23:00 +0000]
Add generated files to doc/xml/AdminGuide .gitignore
Add htmlhelp.hhp, index.hhk, and toc.hhc
Reviewed-on: http://gerrit.openafs.org/259
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Derrick Brashear [Fri, 31 Jul 2009 21:53:18 +0000]
version update for 1.5.61
make configure version strings be 1.5.61
Reviewed-on: http://gerrit.openafs.org/258
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Russ Allbery [Fri, 24 Jul 2009 20:03:48 +0000]
Restore permission documentation in bosserver man page
The original IBM HTML documentation had a table showing the permissions
that bosserver expects and sets when it creates the directory structure
for AFS. That table was accidentally dropped in the conversion to POD.
Restore it from the HTML shipped with an older version of OpenAFS.
Reviewed-on: http://gerrit.openafs.org/210
Tested-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Jeffrey Altman [Thu, 30 Jul 2009 14:23:38 +0000]
Windows: Version and ChangeLog updates for 1.5.61
1.5.61 == 1.5.6100.0
LICENSE MIT
Reviewed-on: http://gerrit.openafs.org/255
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Marc Dionne [Mon, 27 Jul 2009 13:47:08 +0000]
Eliminate some multiple targets in Makefile rules
Rules with multiple targets can cause problems with parallel builds.
This patch fixes two cases that have caused occasional build errors.
Reviewed-on: http://gerrit.openafs.org/257
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Andrew Deason [Thu, 30 Jul 2009 17:43:27 +0000]
Fix UKERNEL afs_mount arguments
Change 73 (commit
dc6299f5) changed the order of arguments for the
UKERNEL implementation of afs_mount, causing uafs_mount to segfault
whenever called. This changes them back to what they were before.
Reviewed-on: http://gerrit.openafs.org/256
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Jeffrey Altman [Thu, 30 Jul 2009 14:00:00 +0000]
Windows: Rename README-NT to README-WINDOWS
Windows has not been referred to as NT in a long time.
We do not support Windows 9x any longer. Rename
README-NT to README-WINDOWS.
Reviewed-on: http://gerrit.openafs.org/254
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Jeffrey Altman [Thu, 30 Jul 2009 13:56:33 +0000]
Windows: Update the README-NT file
Update the README-NT to be more up to date.
It still requires a lot of work.
Reviewed-on: http://gerrit.openafs.org/253
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Andrew Deason [Mon, 20 Jul 2009 17:31:44 +0000]
Add additional vlprocs safety checks
This adds additional safety checks to the vlserver's implementation of
the VL_CreateEntry, VL_ReplaceEntry, and VL_UpdateEntry RPCs. Now in all
three of these, any new volume ID that would be added to the VLDB or
that would be newly referenced in a VLDB entry is checked against
duplication in other entries. Additionally, any new volume names added
to the VLDB (either by creation, or modifying an existing volume) are
checked against duplication. This should make it impossible for clients
to make a volume ID or volume name correspond to multiple volume groups
(either conceptually or literally in the vldb).
This also alters the vlserver's implementation of the VL_GetNewVolumeId
RPC such that the vlserver increments maxvolid until the range of volume
IDs [*newvolumeid, *newvolumeid+bumpcount) is unused. 'vos' is modified
to only allocate one new volume id at a time, so we don't skip over
potentially-usable vol ids.
Reviewed-on: http://gerrit.openafs.org/158
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Derrick Brashear [Thu, 30 Jul 2009 02:56:08 +0000]
macos 10.6 package naming
call the dmg Snowleopard for 10.6.
Reviewed-on: http://gerrit.openafs.org/252
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Derrick Brashear [Thu, 30 Jul 2009 02:14:01 +0000]
macos 10.6 amd64 kmod build fix
make the ARCHFLAGS support for amd64 work correctly by grepping for the correct thing
Reviewed-on: http://gerrit.openafs.org/250
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Derrick Brashear [Wed, 29 Jul 2009 21:23:14 +0000]
macos 10.6 pam support
Make pam module compile on 10.6. Not tested yet.
Reviewed-on: http://gerrit.openafs.org/249
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Marc Dionne [Thu, 30 Jul 2009 02:35:21 +0000]
afs_pag_call.c needs rx/rxstat.h for RXSTATS_ExecuteRequest
This fixes a build error introduced by change 247 (commit
967abaf2).
Reviewed-on: http://gerrit.openafs.org/251
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Simon Wilkinson [Wed, 29 Jul 2009 15:58:03 +0000]
Make rxgen emit prototype for ExecuteRequest
Make rxgen provide a prototype in its header file for _ExecuteRequest, and
remove all of the adhoc prototypes from the tree.
Reviewed-on: http://gerrit.openafs.org/247
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Jeffrey Altman [Wed, 29 Jul 2009 18:31:45 +0000]
Windows: test for and react to SMB Extended Session Timeout support
SMB Extended Session Timeout Support is available only on
Windows systems with specific versions of the mrxsmb.sys driver.
Add a test for those driver versions. If a supporting version
is present use the extended session timeout value instead of the
standard timeout value for the redirector timeout. Adjust the
rx hard, conn, and idle timeouts accordingly.
The SMB module will define the ExtendedSessTimeout registry
value if it does not exist. We rely on the fact that this is
done after the rx timeout values are calculated. The mrxsmb
driver only reads the value at boot.
LICENSE MIT
Reviewed-on: http://gerrit.openafs.org/248
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Asanka Herath <asanka@secure-endpoints.com>
Tested-by: Asanka Herath <asanka@secure-endpoints.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Simon Wilkinson [Tue, 28 Jul 2009 09:32:10 +0000]
Fix signed vs unsigned pointers in volser
Cast iod_Read returns to (char *)
Fix signed vs unsigned pointer argument issues
Reviewed-on: http://gerrit.openafs.org/236
Tested-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Simon Wilkinson [Tue, 28 Jul 2009 10:09:30 +0000]
Code cleanup for vlserver
Move the cnvldb.h include so it's after vlserver.h
Don't define MAXSERVERS in cnvldb.h (it's already defined elsewhere)
Cast nvldbentry(s) to vldbentry to avoid warnings from display_entry
Volume IDs are unsigned
Use var[0]='\0' rather than sprintf(var, "");
Reviewed-on: http://gerrit.openafs.org/237
Tested-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Simon Wilkinson [Tue, 28 Jul 2009 11:25:08 +0000]
Warnings work in util/
Make afs_ctime an inline function, instead of a complex macro.
This both improves our type safety, and suppreses warnings about
unused results.
Add bracing to clarify operator precedence in if (a && b || c)
statement
AFS_DARwiN60_ENV != AFS_DARWIN60_ENV
Use (void) rather than () in function prototypes
Reviewed-on: http://gerrit.openafs.org/240
Tested-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Simon Wilkinson [Tue, 28 Jul 2009 11:13:10 +0000]
Cleanup for the USS directory
Add additional header files for prototypes
Add additional prototypes to header files
yyerror() is internal, not external. Make it static while we're at it.
ANSIfy various function definitions
Unsigned vs signed cleanup
Reviewed-on: http://gerrit.openafs.org/239
Tested-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Derrick Brashear [Tue, 28 Jul 2009 16:13:24 +0000]
install AFSCommander in prefpane dir
make the AFSCommander prefPane be installed, in /Library (as
are growl, macfuse, etc)
Reviewed-on: http://gerrit.openafs.org/243
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Jeffrey Altman [Mon, 27 Jul 2009 16:54:16 +0000]
Protect rx_call iovq from simultaneous attempts to empty it
The iovq queue is not safe to clear without holding the call lock.
FIXES 125110
LICENSE BSD
Reviewed-on: http://gerrit.openafs.org/242
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Hans-Werner Paulsen <hans@MPA-Garching.MPG.DE>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Simon Wilkinson [Tue, 28 Jul 2009 10:55:47 +0000]
Use an anonymous pointer for lpioctl
The block passed to lpioctl as cmarg is an anonymous chunk of
memory, so use a type that represents it as such.
Reviewed-on: http://gerrit.openafs.org/238
Tested-by: Marc Dionne <marc.c.dionne@gmail.com>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Simon Wilkinson [Tue, 28 Jul 2009 11:55:36 +0000]
Additional UKERNEL headers, prototyping and other fixes
Add additonal headers to include prototypes for UKERNEL builds
Add some more prototypes
Remove some unused variables
Reviewed-on: http://gerrit.openafs.org/241
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Marc Dionne <marc.c.dionne@gmail.com>
Simon Wilkinson [Mon, 27 Jul 2009 21:32:01 +0000]
More warnings cleanup for vol/
Prototype a number of functions
Add additional includes as required
Make some existing prototypes match the actual declarations
Volume IDs are unsigned in most of the code, change this bit to match
Make various Procs take an anonymous pointer, so they can be type checked
Add vol_internal.h for prototypes internal to this package
Reviewed-on: http://gerrit.openafs.org/235
Tested-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Simon Wilkinson [Sun, 26 Jul 2009 18:41:30 +0000]
Further warning cleanup for the libadmin directory
More code cleanup for libadmin, including additional header inclusion,
better prototyping, and signed/unsigned and const fixes
Reviewed-on: http://gerrit.openafs.org/228
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Simon Wilkinson [Sun, 26 Jul 2009 18:23:08 +0000]
Move end label into correct position
The end label was in the wrong #ifdef block in order to actually be referenced
in the case where USEIFADDR is unset
Reviewed-on: http://gerrit.openafs.org/226
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Simon Wilkinson [Sun, 26 Jul 2009 18:34:48 +0000]
Additional prototyping in dir.h
Add prototypes for functions used by the file and volservers
Reviewed-on: http://gerrit.openafs.org/227
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Marc Dionne [Mon, 27 Jul 2009 15:29:34 +0000]
Eliminate some "implicit function declaration" warnings
Include appropriate header files to eliminate some warnings for
implicit function declarations. These are simple cases that don't
generate new warnings because of the prototypes.
Use grp.h if it exists to get setgroups() definition.
Reviewed-on: http://gerrit.openafs.org/233
Tested-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Adam Megacz [Mon, 27 Jul 2009 03:32:07 +0000]
In rxi_SendPacket[List], down hosts if ENETUNREACH or equivalent
This patch causes rxi_SendPacket[List] to "down" a host if
rxi_Sendmsg() returns -ENETUNREACH (or equivalent). Previous behavior
only did this check if defined(KERNEL) becauase non-defined(KERNEL)
implementations did not return meaningful error codes from
rxi_Sendmsg().
Jeff Altman <jaltman@openafs.org> supplied the logic for the
AFS_NT40_ENV case; I was not able to test this (I do not own a
Windows license) and took him on his word.
Reviewed-on: http://gerrit.openafs.org/59
Reviewed-by: Adam Megacz <megacz@gmail.com>
Tested-by: Adam Megacz <megacz@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Marc Dionne [Mon, 27 Jul 2009 02:28:29 +0000]
Unused variable cleanup
Eliminate some warnings for unused variables. In most cases the
variables are not used at all and are removed; in a few cases the
declarations need to be ifdef'ed to follow the code that uses them.
For a typical build here this removes 24 warnings.
Reviewed-on: http://gerrit.openafs.org/232
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Jason Edgecombe [Mon, 27 Jul 2009 01:26:59 +0000]
Future-proof the wording of the auditlog options in the man pages
It was suggested that the auditlog option should not say there is one
record per RPC. In the future, there might be a need for multiple records
per RPC.
LICENSE BSD
Reviewed-on: http://gerrit.openafs.org/229
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Marc Dionne [Mon, 27 Jul 2009 01:45:33 +0000]
Build fix - pre-processor typos in rx_lwp.c and rx_pthread.c
Commit
119c756d96c4a7f9e01e4ff6bb20156f1abf761b introduced a typo
in two places, using #elif instead of the apparently intended #else.
Reviewed-on: http://gerrit.openafs.org/231
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Adam Megacz [Sun, 19 Jul 2009 18:00:41 +0000]
Use -errno or WSAGetLastError() as return value from rxi_Sendmsg()
This patch causes the pthread and lwp implementations of rxi_Sendmsg()
to use -errno or WSAGetLastError() as the return value if it is
positive. This is required in order to communicate more meaningful
error conditions to rxi_SendPacket[List], which should "down" a host
immediately when it observes ENETUNREACH.
Jeff Altman <jaltman@openafs.org> supplied the logic for the
AFS_NT40_ENV case; I was not able to test this (I do not own a
Windows license) and took him on his word.
Reviewed-on: http://gerrit.openafs.org/58
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Adam Megacz <megacz@gmail.com>
Tested-by: Adam Megacz <megacz@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Jeffrey Altman [Sun, 26 Jul 2009 17:03:49 +0000]
Windows: Add buf_FindAll() and buf_FindAllLocked()
Add two new buffer search functions buf_FindAll and buf_FindAllLocked.
Similar to buf_Find and buf_FindLocked except they search the all buffer
list.
LICENSE MIT
Reviewed-on: http://gerrit.openafs.org/225
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Jeffrey Altman [Sun, 26 Jul 2009 16:57:10 +0000]
Windows: Add cm_GetVolumeType
Add new volume utility function cm_GetVolumeType which returns
the type of volume based upon provided volume group and volume id.
LICENSE MIT
Reviewed-on: http://gerrit.openafs.org/224
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Jeffrey Altman [Sun, 26 Jul 2009 16:20:26 +0000]
Windows: Add cm_req_t parameter to cm_MergeStatus
cm_MergeStatus allocates its own local cm_req_t object even
though all of its callers already have an active cm_req_t object
available.
LICENSE MIT
Reviewed-on: http://gerrit.openafs.org/223
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Jeffrey Altman [Sun, 26 Jul 2009 15:54:27 +0000]
Windows: Add cm_req_t parameter to buf_Get* functions
The buf_Get* functions do not currently accept a cm_req_t
parameter. As a result they allocate their own cm_req_t on
the stack even though all callers already have one that can
be used.
LICENSE MIT
Reviewed-on: http://gerrit.openafs.org/222
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Jeffrey Altman [Sun, 26 Jul 2009 15:48:37 +0000]
Windows: Add enhanced audit log to afsauthent.dll
Add the enhanced audit log support to afsauthent.dll.
Reviewed-on: http://gerrit.openafs.org/221
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Jeffrey Altman [Sun, 26 Jul 2009 15:01:43 +0000]
Permit enhanced audit logs to work on Windows
Gerrit 82 / Git
7b0b6a0ce9b320a3145f9d600596946230d815f0
broke the Windows build.
Add audit-file.obj to file list in NTMakefile.
Remove unnecessary includes from audit.c.
Properly conditionalize includes in audit-file.c.
Reviewed-on: http://gerrit.openafs.org/219
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Asanka Herath [Sun, 26 Jul 2009 14:16:33 +0000]
Windows: Tests for afsd modules
Add test routines for internationalization routines.
LICENSE MIT
Reviewed-on: http://gerrit.openafs.org/218
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Jason Edgecombe [Sat, 25 Jul 2009 17:37:08 +0000]
Expanded the -auditlog entries in the man pages of the server processes
The expanded auditlog explanation includes what information is recorded
in the auditlog.
LICENSE BSD
Reviewed-on: http://gerrit.openafs.org/213
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
matt@linuxbox.com [Wed, 22 Jul 2009 19:43:22 +0000]
Portable lock-free data structures by Keir Fraser (MCAS)
The MCAS suite, previously released as lock-free library, under a
non-restrictive license.
This software includes software previously released in 2003 under a
GPL license, but released by the original copyright holder, Keir
Fraser, under a BSD license, on 5/28/2008.
Reviewed-on: http://gerrit.openafs.org/183
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Russ Allbery [Fri, 24 Jul 2009 20:38:09 +0000]
Document human-readable size suffixes
Document that the quotas passed to fs setquota, vos create, and vos
setfields and the size passed to fs setcachesize may take a suffix
indicating the unit. This documents the change in behavior implemented by
54c0a3f3e6575fa5af39ddd797d5381c36b48001.
Fix a copy/paste error in the vos create -maxquota option definition.
Reviewed-on: http://gerrit.openafs.org/212
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Andrew Deason [Wed, 24 Jun 2009 21:46:27 +0000]
Enhance audit logs to support SysV message queues
Adds support for sysv message queues for fileserver audit logs. This
also organizes the audit log code into various 'interfaces', of which
there are two: the original 'file' interface, and the 'sysvmq' interface
that this adds. The interface is configurable at runtime with the
-audit-interface switch.
FIXES 124674
Reviewed-on: http://gerrit.openafs.org/82
Tested-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Andrew Deason [Mon, 6 Jul 2009 15:29:20 +0000]
Allow specifying vos create/addsite volume IDs
This adds the -id option to 'vos create', and the -roid option to 'vos
create' and 'vos addsite'. This allows the user to manually specify the
volume IDs that a new RW or RO volume will get (or explicitly specify
that an RO volume ID should be unset), instead of always relying on the
volume IDs retrieved from the vlserver.
Reviewed-on: http://gerrit.openafs.org/157
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Jeffrey Altman [Fri, 24 Jul 2009 16:58:26 +0000]
Running bos -noauth should not require client CellServDB configuration
When setting up a new cell, the admin is instructed to use "bos -noauth"
to configure the servers and only afterwards create the client configuration.
This leads to a catch-22 since currently bos -noauth fails if there is no
client configuration even though it is not required.
This change avoids the call to afsconf_Open() which is only required
if tokens are being acquired.
FIXES 125156
Reviewed-on: http://gerrit.openafs.org/209
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Derrick Brashear [Fri, 24 Jul 2009 04:44:31 +0000]
afsprefs pane shouldn't hardcode 10.4 sdk
10.4 sdk isn't available in the release after 10.5 as a default. don't hardcode it
same with afscell
Reviewed-on: http://gerrit.openafs.org/207
Tested-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Jeffrey Altman [Fri, 24 Jul 2009 02:23:13 +0000]
Windows: Move src/NTMakefile to top-level in order to avoid copying
For some unknown reason the Windows top-level NTMakefile is stored
at src/NTMakefile and must be copied to the top-level before it can
be used. Now that git permits easy file moves, relocate src/NTMakefile
to where it belongs.
Reviewed-on: http://gerrit.openafs.org/206
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Simon Wilkinson [Thu, 23 Jul 2009 19:33:36 +0000]
Make buildpkg work out of tree
Don't reference files in the local directory, so that buildpkg.sh can be
invoked from elsewhere
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/202
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Toby Blake [Thu, 23 Jul 2009 19:18:28 +0000]
Finish afscell implementation work
This patch completes the implementation of an install time prompeter
for information about the local AFS cell, which is then used to populate
the ThisCell file. It removes the need for manual editing of
configuration files as part of the installation.
(Build system modified by Simon Wilkinson from Toby's original patch)
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/201
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Derrick Brashear [Thu, 23 Jul 2009 19:42:14 +0000]
correct macos 10.6 amd64 support
add a missing space so the kernel module can link
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/203
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Simon Wilkinson [Thu, 23 Jul 2009 18:27:47 +0000]
Move afscell to platform/DARWIN
Move our current afscell code into platform/DARWIN so that it's in a
location that can be added to the build, rather than packaging, step
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/200
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Marc Dionne [Thu, 23 Jul 2009 20:52:46 +0000]
Fix build error - libafsrpc.map syntax
Fix a build error introduced by commit 3a6d18:
/usr/bin/ld:./libafsrpc.map:125: syntax error in VERSION script
There seems to be a missing semicolon with the new rx_GetLocalPeers
entry.
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/205
Reviewed-by: Jacob Thebault-Spieker <summatusmentis@gmail.com>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Russ Allbery [Sat, 18 Jul 2009 18:38:22 +0000]
Clean up some obsolete Autoconf code
Remove hand-crafted equivalents of AC_SEARCH_LIBS for socket, connect,
and gethostbyname functions. The only effective difference between
this code and AC_SEARCH_LIBS was to define the HAVE_* macros for the
functions, which are not used anywhere in the tree.
Remove AC_FUNC_SETVBUF_REVERSED. This call no longer does anything in
current versions of Autoconf since the last system with this problem
was based on SVR2 and became obsolete in 1987. Remove the one place in
the source tree where the results are used.
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/154
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Jeffrey Altman [Thu, 23 Jul 2009 19:43:55 +0000]
Windows: rename compile_et.pod to afs_compile_et.pod
Gerrit 175 renamed compile_et and compile_et.pod to afs_compile_et*.
Fix the Windows build system to process the new pod file name
and modify the WiX installer scripts to install afs_compile_et.html.
FIXES 125152
LICENSE MIT
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/204
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Simon Wilkinson [Tue, 21 Jul 2009 19:53:57 +0000]
Further code cleanup for the backup suite
Protect butm.h against multiple inclusion
Prototype more functions for internal use in bucoord
Remove some unused variables
Include additional headers as required
Prototype exported functions in budb
Make SendReturnList helper function generic, by using a void * rock
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/168
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Simon Wilkinson [Thu, 23 Jul 2009 17:44:42 +0000]
Remove duplicate copy of afssettings.m
afssettings.m lives in src/platform/DARWIN. Remove the duplicate copy
from this directory, and the (now unnecessary) Makefile.
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/199
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Simon Wilkinson [Wed, 22 Jul 2009 00:11:15 +0000]
Rename installed version of compile_et
Rename the installed version of compile_et to afs_compile_et to avoid
conflicts with other, more standard, users of com_err. Also rename the
man page to match
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/175
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Matt Benjamin [Tue, 21 Jul 2009 21:07:36 +0000]
Refactor OpenBSD param files into common and architecture-specific
sections.
The new structure follows the pattern of the NetBSD param files, as
suggested by Derrick. Since the change is retroactive, it seems
reasonable to also make the retroactive change to add the amd64 param
files, back to OpenBSD 3.6. OpenBSD 3.6 added SMP support for x86_64,
so the architecture was a mature subtarget at that point.
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/177
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Russ Allbery [Tue, 21 Jul 2009 18:04:41 +0000]
Fix warnings in vlserver/vlprocs.c
rxinfo's code to print out the principal corresponding to an rx_call uses
static arrays for the principal components but was checking that the array
pointer was non-NULL when deciding whether to print principal components.
Instead check whether each portion of the principal is the empty string.
Add explicit initializations of the static buffers to the empty string so
that we're not relying on rxkad_GetServerInfo always initializing them for
us.
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/163
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Jeffrey Altman [Wed, 15 Jul 2009 07:58:02 +0000]
Modify Solaris Rx NetIfPoller to avoid Panic
This patch changes the common error reporting type from CE_PANIC
to CE_WARN and adds appropriate cleanup processing so that we do not
leak resources if an error occurs.
LICENSE MIT
FIXES 124498
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/97
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Simon Wilkinson [Wed, 22 Jul 2009 21:07:32 +0000]
Squish more warnings in xstat
Use a correct prototype for a_ProbeHandler in xstat_cm_Init
Fix a printf warning
rx_getAllAddr and afs_cb_interface.addr disagree on the sign of addresses
afs_interface.addr is a [], which we then use & to get the address of. Fix
this to stop the compiler from sulking.
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/184
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Simon Wilkinson [Wed, 22 Jul 2009 21:40:13 +0000]
Do not call principal_ntoh to copy ktc_principal structs
principal_ntoh() is designed for butc_principal structures, which are a
different size from ktc_principal structures, and so it can't be used to
copy them.
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/185
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Derrick Brashear [Thu, 23 Jul 2009 15:46:50 +0000]
platform makefile should handle clean target
pass "make clean" through to platform-specific makefiles
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/198
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Claudio Bisegni [Thu, 23 Jul 2009 14:40:39 +0000]
Makefile.in modification for compile AFSPreference source code
Have been added the rule "OpenAFS.prefPane" tha compile with xcodebuild the xcode project
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/197
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Claudio Bisegni [Fri, 10 Jul 2009 22:18:56 +0000]
OSX Preference Pane Source Import
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/196
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Jacob Thebault-Spieker [Wed, 22 Jul 2009 21:56:32 +0000]
Expose locally collected rx peer statistics
This implements rx_GetLocalPeers(), which exposes peer statistics
that are currently collected to the cache manager. This function
will later be used to rank both the file server and vldb server
lists using the statistics exposed by rx_GetLocalPeers().
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/186
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Claudio Bisegni [Fri, 10 Jul 2009 22:18:04 +0000]
OSX Preference Pane
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/195
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Mickey Lane [Thu, 23 Jul 2009 13:20:27 +0000]
Update Windows strcmpi call
This POSIX function is deprecated beginning in Visual C++ 2005
Change to _stricmp instead
This change affects 4 calls in 3 Windows only files.
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/188
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Jeffrey Altman [Thu, 23 Jul 2009 14:12:02 +0000]
Windows: Fix cm_UpdateVolumeStatusInt log message
In the server "down" case, the log message reported "online".
Fix that to avoid confusion while debugging.
LICENSE MIT
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/194
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Mickey Lane [Wed, 22 Jul 2009 18:55:02 +0000]
Remove 8.3 dir requirement for Windows IDN path
This adds double quotes around the IDNMRedistDir symbol in ..\wix\NTMakefile
so that the 8.3 alternate directory name is no longer required.
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/182
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Russ Allbery [Wed, 22 Jul 2009 14:00:10 +0000]
Remove conditional on LINUX/osi_pag_module.c
osi_pag_module.c should not be built conditionally based on whether the
NFS translator is enabled. This file is used by afspag.ko, which is run
on NFS translator clients, not servers, and should not have GPL symbol
problems.
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/179
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Felix Frank [Thu, 2 Jul 2009 06:55:47 +0000]
Unite CacheStoreProcs and add abstraction calls.
The cache type specific differencies among afs_MemCacheStoreProc
and afs_UFSCacheStoreProc are divided into two sets of "storeOps".
Upon rxfs_storeInit, the appropriate set is chosen.
FIXME: Simon suggests that there should be a single set of storeOps,
as the main difference lies in what rx_ calls must be made.
This decision would then be made by calling a wrapper function from
each storeOp. These wrappers should be cachetype-specific and protocol-
independent. They would be associated to struct afs_cacheOps.
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/107
Tested-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Simon Wilkinson [Tue, 21 Jul 2009 19:58:36 +0000]
Fix warnings in comerr directory
Prototype yylex in error_table.y to remove warning
Fix the bizarre definition of LOCK_ET_LIST so that it upsets neither the
compiler, nor the reader.
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/169
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Simon Wilkinson [Tue, 21 Jul 2009 19:16:51 +0000]
Further prototyping and cleanup of UKERNEL
This patch continues to reduce the number of warnings that come from
a UKERNEL build. It also replaces the use of a system provided suser()
call (which isn't available everywhere), with afs_suser that's provided
by UKERNEL. Note that this makes UKERNEL applications usable by
everyone, not just root.
fork_syscall() becomes a normal function
call_syscall() is ANSIfied
UKERNEL/osi_groups.c gets the includes it needs
UKERNEL/osi_machdep.c stops thinking it's on Solaris
UKERNEL/osi_vnodeops.c stops confusing vnodes and vcaches
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/166
Tested-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Hans-Werner Paulsen [Mon, 20 Jul 2009 10:06:23 +0000]
Use Posix regex(3) within src/bucoord/commands.c
Normally pattern matching against volume names is done on the server, but
if this fails, the client (src/bucoord/commands.c) is doing this.
This program had no code to use regex(3) when HAVE_POSIX_REGEX is defined.
This patch adds calls to regex(3) if HAVE_POSIX_REGEX is defined.
For systems without POSIX regex there were two (slightly different)
implementations in src/bucoord/regex.c and src/util/regex.c. The newer
version src/bucoord/regex.c has been modified and moved to src/util/regex.c.
Some header files and Makefiles have been removed/updated to work with this
setup.
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/99
Tested-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Marc Dionne [Tue, 21 Jul 2009 22:16:45 +0000]
Build fixes: prevent unnecessary rebuilding
Fixes to a few Makefiles to prevent needless rebuilding when using make
after a successful build.
Rework dependencies in src/bubasics to prevent needless rebuilding and
fix some remaining parallel build issues. Multiple targets really
have to be avoided.
Remove dependency on the include/afs directory from the src/config Makefile.
Depending on a directory means that we will rebuild the target if the
timestamp changes, for instance if other files or sub-directories are
installed. This caused param.h to get re-installed in some cases and
the kernel module source files to be recompiled. This directory is
created in the top-level Makefile anyway so we shouldn't need an
explicit dependency.
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/171
Tested-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Russ Allbery <rra@stanford.edu>
Hans-Werner Paulsen [Wed, 22 Jul 2009 13:14:33 +0000]
avoid call to rxi_FreePacket with NULL pointer
the function rx_ReadProc32 (src/rx/rx_rdwr.c) checks the pointer
call->currentPacket before the function rxi_FreePacket is called. This
test was missing in the function rx_ReadProc.
FIXES 125110
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/178
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Derrick Brashear [Tue, 21 Jul 2009 21:09:39 +0000]
OSX lock initialization cleanup
Move GLOCK creation before other things at modload time. Also
remove unused rwlock support from rx kmutex package.
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/170
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Matt Benjamin [Sat, 18 Jul 2009 13:29:20 +0000]
Add amd64 subtarget for OpenBSD
The subtarget name is amd64_obsd. A sysname is created for the
OpenBSD 4.5 release, since it's current. The sysname id range starting at
4000 is claimed for amd64_obsd, with amd64_obsd45 at 4014, so that prior
releases can be added in the correct order, if needed.
Mention of Jim Rees and CITI in new param file changed to line crediting
them for original work.
Reviewed-on: http://gerrit.openafs.org/http://gerrit.openafs.org/153
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>