openafs.git
12 years agoWindows: Explorer Shell Invalid Parameter Errors
Jeffrey Altman [Sat, 5 Sep 2009 03:23:10 +0000]
Windows: Explorer Shell Invalid Parameter Errors

The attempt to follow the smb protocol specification by returning
extended responses to NTCreateAndX requests (when specified)
resulted in random "invalid parameter" errors from the Explorer
Shell (and common control dialogs) on Vista SP2.
As a result we won't send the extended responses.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/399
Tested-by: Asanka Herath <asanka@secure-endpoints.com>
Reviewed-by: Asanka Herath <asanka@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: Freelance get callback sync and uninitialized variables
Jeffrey Altman [Sat, 5 Sep 2009 03:13:52 +0000]
Windows: Freelance get callback sync and uninitialized variables

In cm_GetCallback the Freelance mode case did not properly
synchronize attempts to fake obtain a callback.

cm_GetCallback also failed to initialize the contents of afsStatus and
volSync which are used as input to cm_MergeStatus.
cm_MergeStatus special cased the freelance root.afs volume root
directory but failed to handle any other freelance volume objects.
As a result it used the contents of the uninitialzed input structures
to populate the status of the object for which the callback was
obtained.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/401
Tested-by: Asanka Herath <asanka@secure-endpoints.com>
Reviewed-by: Asanka Herath <asanka@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agomake afsd partition size check be large partition safe
Derrick Brashear [Tue, 1 Sep 2009 17:00:00 +0000]
make afsd partition size check be large partition safe

right now the math overflows the 32 bit type for >2tb partitions.
use larger variables to avoid this.

Reviewed-on: http://gerrit.openafs.org/392
Reviewed-by: Matt Benjamin <matt@linuxbox.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoUpdate accessDate on volume access
Andrew Deason [Mon, 31 Aug 2009 16:10:10 +0000]
Update accessDate on volume access

Right now accessDate is simply never updated, so the last access time
for a volume is never reported. Simply update the field in
VBumpVolumeUsage_r, so we track the last time the volume was accessed.

Note that this does not increase disk writes to the volume header; the
performance impact is effectively nil.

Reviewed-on: http://gerrit.openafs.org/385
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoAdd tracing to MCAS allocator and GC
matt@linuxbox.com [Fri, 28 Aug 2009 15:54:41 +0000]
Add tracing to MCAS allocator and GC

Adds conditional trace logging to MCAS object cache and supporting GC,
using ViceLog.  While in future this should be normalized, it is correct
for both fileserver and volserver, the two programs using MCAS currently.

LICENSE BSD

Reviewed-on: http://gerrit.openafs.org/374
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoUpdated Chapter 2, Section 3.4 of the Admin Guide
Jason Edgecombe [Sun, 30 Aug 2009 22:26:10 +0000]
Updated Chapter 2, Section 3.4 of the Admin Guide

Added a bullet point explaining the use of a Kerberos cross-realm trust and PTS
foreign groups to give foreign users access.

Replaced a reference to Authentication Database with Kerberos Database.

LICENSE BSD

Reviewed-on: http://gerrit.openafs.org/381
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoWindows: The unnamed stream is a synonym
Jeffrey Altman [Thu, 3 Sep 2009 02:49:40 +0000]
Windows: The unnamed stream is a synonym

Treat a file request for "name::$DATA" as if it were specified as
"name".  Otherwise, the inclusion of the colon in the file name
will cause it to be treated as invalid.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/395
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: rx_Write failures must be processed
Jeffrey Altman [Thu, 3 Sep 2009 02:54:17 +0000]
Windows: rx_Write failures must be processed

The error code returned by rx_Write takes precedence under
all circumstances over the error returned by EndRXAFS_StoreData.

cm_ReleaseBIOD must apply the error code to all buffers in the
BIOD list.

cm_ReleaseBIOD accepts an error code, not a boolean indicating
failure.

Fix a related signed/unsigned error.

FIXES 125351

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/396
Tested-by: Asanka Herath <asanka@secure-endpoints.com>
Reviewed-by: Asanka Herath <asanka@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: avoid inappropriate dns searches
Jeffrey Altman [Thu, 3 Sep 2009 02:44:33 +0000]
Windows: avoid inappropriate dns searches

Do not perform searches for cells if the string prefix
matches _._AFS_IOCTL_._.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/394
Tested-by: Asanka Herath <asanka@secure-endpoints.com>
Reviewed-by: Asanka Herath <asanka@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoUpdated Chapter 2, Section 3.2 of the Admin Guide
Jason Edgecombe [Sun, 30 Aug 2009 21:54:16 +0000]
Updated Chapter 2, Section 3.2 of the Admin Guide

Removed the reference to the Authentication Server and added a reference to the Kerberos Server and Kerberos 5 authentication for foreign clients.

Replaced AFS Product Support with the AFS registrar as the maintainer of the
public CellServDB file. A link was added to grand.central.org for getting the
latest copy of the file and submitting changes for the local site.

Reviewed-on: http://gerrit.openafs.org/379
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoSALVSYNC_com initialization typo
Andrew Deason [Wed, 2 Sep 2009 16:50:06 +0000]
SALVSYNC_com initialization typo

The size of sres_hdr is sizeof(sres_hdr), not sizeof(sres).

Reviewed-on: http://gerrit.openafs.org/393
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoTurn on --enable-bos-new-config unconditionally
Russ Allbery [Fri, 24 Jul 2009 20:18:31 +0000]
Turn on --enable-bos-new-config unconditionally

Remove the conditional and Autoconf flag for enabling BosConfig.new
handling and change bosserver to always rename BosConfig.new to BosConfig
on startup if the former exists.

Document BosConfig.new handling in the bosserver and BosConfig man pages.
Tone down the warning about the BosConfig file format changing and warn
that bosserver rewrites BosConfig when shutting down.

Reviewed-on: http://gerrit.openafs.org/211
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoDAFS: avoid shutdown hang during salvage
Andrew Deason [Wed, 29 Jul 2009 15:56:34 +0000]
DAFS: avoid shutdown hang during salvage

Right now, when the fileserver shuts down, it tries to cancel any
demand-salvages in progress. This causes the fileserver to hang, since
during shutdown, the salvageserver may already be gone. This avoids
cancelling in-progress salvages, and allows salvages to continue after
the fileserver has shut down.

To do this, the salvageserver now closes SALVSYNC sockets in spawned
children, so the children don't get SALVSYNC requests directed at them,
since they can't handle them. The salvageserver also now periodically
scans for logs of salvaging children that have terminated, and
incorporates them into SalsrvLog, just like it does for it's own
children. The salvageserver children that actually perform salvages now
also set the inUse volume header field to their programType, so the
fileserver knows not to schedule new salvages for that volume in the
event of a fileserver restart during a salvage.

FIXES 124486

Reviewed-on: http://gerrit.openafs.org/279
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoUploaded patchset 9. Sorry for the mess.
Christof Hanke [Tue, 1 Sep 2009 12:33:53 +0000]
Uploaded patchset 9. Sorry for the mess.

Reviewed-on: http://gerrit.openafs.org/125
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoFix cache tracking for small fragsizes
Andrew Deason [Thu, 27 Aug 2009 17:43:03 +0000]
Fix cache tracking for small fragsizes

The tracked amount of disk cache used by a client can be incorrect when
afs_fsfragsize is tuned to below 1023. Since we round up to the next
nearest afs_fsfragsize+1 then round down to the kb, if afs_fsfragsize+1
< 1kb, we can undershoot the cache usage.

This enforces afs_fsfragsize to always be at least 1023.

Reviewed-on: http://gerrit.openafs.org/338
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoUpdated Chapter 2, Section 3.3 of the Admin Guide
Jason Edgecombe [Sun, 30 Aug 2009 22:13:06 +0000]
Updated Chapter 2, Section 3.3 of the Admin Guide

Added text about Freelance Mode and Dynamric Root Mode and the changes they
cause when dealing with mounts to foreign cells in /afs and \\AFS

Reviewed-on: http://gerrit.openafs.org/380
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoRemove unnecessary type ViceFid
Christof Hanke [Mon, 31 Aug 2009 13:39:02 +0000]
Remove unnecessary type ViceFid

The type "ViceFid" is just a clone of the type AFSFid and used only in a couple of places.
Thus, for simplicity, rename all occurences of ViceFid to AFSFid and remove the
typedef itself.

Reviewed-on: http://gerrit.openafs.org/383
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoWindows: Permit cygwin apps to read from AFS again
Jeffrey Altman [Tue, 1 Sep 2009 00:10:13 +0000]
Windows: Permit cygwin apps to read from AFS again

For some reason specifying a unique GUID for each open
file based on the cm_fid results in cygwin apps being
unable to read from AFS.  ReadFile() calls fail with
Invalid Device Request errors instead.

While fixing that issue discovered that not all of the
data was properly set for QueryPathInfoAll operations.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/388
Tested-by: Asanka Herath <asanka@secure-endpoints.com>
Reviewed-by: Asanka Herath <asanka@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: uninitialized variable
Jeffrey Altman [Tue, 1 Sep 2009 00:08:53 +0000]
Windows: uninitialized variable

Ensure that the index variable used to walk the fid history
of the current evaluated path is always initialized.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/389
Tested-by: Asanka Herath <asanka@secure-endpoints.com>
Reviewed-by: Asanka Herath <asanka@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: integrated logon
Jeffrey Altman [Tue, 1 Sep 2009 00:06:27 +0000]
Windows: integrated logon

The previous fix prevented a null pointer dereference but
forgot to set 'effDomain' to the domain specified by the
caller if it exists and is not the local machine name.

LICENSE MIT

FIXES 125325

Reviewed-on: http://gerrit.openafs.org/390
Tested-by: Asanka Herath <asanka@secure-endpoints.com>
Reviewed-by: Asanka Herath <asanka@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoMake catalog file destdir when not transarc paths
Matt Benjamin [Mon, 31 Aug 2009 12:57:55 +0000]
Make catalog file destdir when not transarc paths

The appropriate mkdir -p was missing for this case, the patch adds it.

Reviewed-on: http://gerrit.openafs.org/387
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoRemove AFS_KERBEROS_ENV in NetBSD 30, 40 param files
Matt Benjamin [Mon, 31 Aug 2009 10:16:27 +0000]
Remove AFS_KERBEROS_ENV in NetBSD 30, 40 param files

This creates dependency on ktc_newpag, which has been determined to be
obsolete.

Reviewed-on: http://gerrit.openafs.org/384
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoBuild shared afsauthent and afsrpc on *BSD
Matt Benjamin [Sun, 30 Aug 2009 17:30:18 +0000]
Build shared afsauthent and afsrpc on *BSD

This seems to be a required step, going forward.  Omitting breaks pam,
for example.

Reviewed-on: http://gerrit.openafs.org/382
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoFixed the tokens update and update .gitignore for MacOSX packaging file
Claudio Bisegni [Fri, 28 Aug 2009 19:16:52 +0000]
Fixed the tokens update and update .gitignore for MacOSX packaging file

Fixed the tokens update on preference pane if operation is made with NSStatusItem.
Has been updated the src/packaging/MacOS/.gitingore for CellServDB file and src/libafs/.gitignore has been added afs.x86_darwin_100.plist.

Reviewed-on: http://gerrit.openafs.org/372
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agodoc: typo fix in asetkey man page example
Michael Meffie [Fri, 28 Aug 2009 15:40:01 +0000]
doc: typo fix in asetkey man page example

Fixed a typo in the asetkey man page.

Reviewed-on: http://gerrit.openafs.org/373
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agomacos 10.5 doesn't support compiler kext flag openafs-devel-1_5_62
Derrick Brashear [Fri, 28 Aug 2009 05:01:46 +0000]
macos 10.5 doesn't support compiler kext flag

-kext was added in later xcodes; it's safer to just assume we don't
have it.

Reviewed-on: http://gerrit.openafs.org/365
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoWindows: Version Update 1.5.6200.0
Jeffrey Altman [Thu, 27 Aug 2009 20:17:24 +0000]
Windows: Version Update 1.5.6200.0

Version update to 1.5.6200.0

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/354
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: SMB Server does not support streams, so say that
Jeffrey Altman [Thu, 27 Aug 2009 07:59:02 +0000]
Windows: SMB Server does not support streams, so say that

The SMB server does not support streams.  When replying to
NT Create operations with extended responses report that
there are no streams.  In addition, add support for Query
Path/File Stream Information and return only the null stream.

Correct the 'totalData' response field in several places
within Trans2QPathInfo and Trans2QFileInfo.

Return CM_ERROR_BADOP for SMB NT Transact operations that
are not supported instead of CM_ERROR_INVAL.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/347
Tested-by: Asanka Herath <asanka@secure-endpoints.com>
Reviewed-by: Asanka Herath <asanka@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoCorrect description of afs krb.conf file format
Jeffrey Altman [Thu, 27 Aug 2009 19:29:50 +0000]
Correct description of afs krb.conf file format

The file format is a single line containing one or more realms
separated by white space.

LICENSE BSD

Reviewed-on: http://gerrit.openafs.org/352
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoupdate decode-panic for 10.6
Derrick Brashear [Thu, 27 Aug 2009 19:47:58 +0000]
update decode-panic for 10.6

how panics get reported changed in 10.6. also, the 64 bit universal kext
means we don't know what the last boot was.

Reviewed-on: http://gerrit.openafs.org/353
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agomake openafs 1.5.62
Derrick Brashear [Thu, 27 Aug 2009 15:18:41 +0000]
make openafs 1.5.62

update version strings for 1.5.62

Reviewed-on: http://gerrit.openafs.org/351
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agomacos afs prefspane support for 10.4
Derrick Brashear [Thu, 27 Aug 2009 12:12:31 +0000]
macos afs prefspane support for 10.4

NSUInteger is newer than what's included in the 10.4 SDK. restore
functionality for 10.4

Reviewed-on: http://gerrit.openafs.org/349
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agocorrect GetuTime function name
Derrick Brashear [Thu, 27 Aug 2009 14:12:13 +0000]
correct GetuTime function name

GetuTime is really osi_GetuTime

Reviewed-on: http://gerrit.openafs.org/350
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agomacos 10.6 64 bit support
Derrick Brashear [Wed, 26 Aug 2009 21:34:50 +0000]
macos 10.6 64 bit support

support 64 bit userland with 32 bit kernel, and
32 and 64 bit userland with 64 kit kernel

Reviewed-on: http://gerrit.openafs.org/343
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoredefine xdr functions consistently
Derrick Brashear [Thu, 27 Aug 2009 11:53:00 +0000]
redefine xdr functions consistently

if we redefine the names of all xdr_ functions, the same must be done
for xdr_alloc and xdr_free

Reviewed-on: http://gerrit.openafs.org/348
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoWindows: Release Notes Updates for 1.5.62
Jeffrey Altman [Thu, 27 Aug 2009 02:31:58 +0000]
Windows: Release Notes Updates for 1.5.62

Some formatting corrections

Section 3.26 updated to describe limitations caused by Apple
Bonjour on 32-bit Windows.

Section 3.40 updated to mentions Microsoft SMB Redirector
Extended Server Timeout support.

Section 3.41 updated to describe inability of pioctl operations
to succeed on service mapped drives.

Section 3.43 updated to include Windows 7 and Server 2008
in the known issues list.

New section 3.51 on Microsoft RPC Services

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/346
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: Updates to Windows ChangeLog
Jeffrey Altman [Wed, 26 Aug 2009 21:32:31 +0000]
Windows: Updates to Windows ChangeLog

1.5.6200

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/345
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agomacos rc script server handling
Derrick Brashear [Wed, 26 Aug 2009 19:15:27 +0000]
macos rc script server handling

only start bosserver if its configured. shut it down if we (likely) started it

Reviewed-on: http://gerrit.openafs.org/344
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoInitialize xferStartTime for StoreData timings
Russ Allbery [Wed, 26 Aug 2009 04:00:33 +0000]
Initialize xferStartTime for StoreData timings

In the reorganization of fetch and store procs, the initialization of
the transfer start time for a store was lost, leading to meaningless
statistics from the uninitialized variable.  Initialize the transfer
time at the start of transferring each chunk and move the variable into
the for loop.

Reviewed-on: http://gerrit.openafs.org/340
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoAdd automatic sysname detection for ARM Linux
Russ Allbery [Sat, 22 Aug 2009 01:37:41 +0000]
Add automatic sysname detection for ARM Linux

Add arm*-linux* to the case statement that attempts to automatically
determine the AFS sysname, similar to the other Linux sysname
determination cases.

Reviewed-on: http://gerrit.openafs.org/334
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years ago10.6 update(Workaround for kerberos bug) and cleaning of deprecated function form...
Claudio Bisegni [Wed, 26 Aug 2009 15:18:37 +0000]
10.6 update(Workaround for kerberos bug) and cleaning of deprecated function form code

For aklog has been added the workaround for kerberos function KLAcquireInitialTickets that in 10.6 return always error.
First is called KLCacheHasValidTickets for check user ticket presence, if there are no ticket  KLAcquireNewInitialTickets will be called for get user credential.
Has been removed also many deprecated api.

Reviewed-on: http://gerrit.openafs.org/341
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoSome renames and reformattings in afs_fetchstore
Felix Frank [Wed, 15 Jul 2009 12:11:32 +0000]
Some renames and reformattings in afs_fetchstore

Reviewed-on: http://gerrit.openafs.org/124
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>

12 years agoSanity for the padd storeOp
Felix Frank [Fri, 10 Jul 2009 13:55:58 +0000]
Sanity for the padd storeOp

Reviewed-on: http://gerrit.openafs.org/123
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>

12 years agoAdd the padd storeOp and unify statistics keeping.
Felix Frank [Wed, 8 Jul 2009 14:36:34 +0000]
Add the padd storeOp and unify statistics keeping.

Filling with zeroes is done within a storeop of its own. This raises
consistency and readability.
Also, the formerly copy-pasted (to afs_dcache and afs_segments respectively)
statistics code is now in a seperate function of its own.

Reviewed-on: http://gerrit.openafs.org/122
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>

12 years agoWindows: MSRPC_WriteMessage, call MSRPC_NewCall at right time
Jeffrey Altman [Tue, 25 Aug 2009 19:46:01 +0000]
Windows: MSRPC_WriteMessage, call MSRPC_NewCall at right time

In MSRPC_WriteMessage, call MSRPC_NewCall after checking for
MAX_RPC_MSG_SIZE and return an error if MSRPC_NewCall fails.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/339
Reviewed-by: Asanka Herath <asanka@secure-endpoints.com>
Tested-by: Asanka Herath <asanka@secure-endpoints.com>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoCleanups in rxfs_storeInit()
Felix Frank [Tue, 14 Jul 2009 10:46:08 +0000]
Cleanups in rxfs_storeInit()

Reviewed-on: http://gerrit.openafs.org/121
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>

12 years agoMore CacheStoreProc call context to afs_fetchstore from afs_segments
Felix Frank [Tue, 14 Jul 2009 10:42:44 +0000]
More CacheStoreProc call context to afs_fetchstore from afs_segments

The loop over the dcaches is performed in afs_fetchstore now as well,
in a new routine afs_CacheStoreVCache that is called in afs_CacheStoreProc's
stead. The original afs_CacheStoreProc has largely moved to
afs_CacheStoreDCaches in afs_fetchstore.c.

Enhances readability of afs_StoreAllSegments. rxfs_storeInit() can be
performed earlier now, which is instrumental for the inclusion of
alternative protocols (which will call other storeInit() functions).

Reviewed-on: http://gerrit.openafs.org/120
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>

12 years agoLimited the scope of some local variables in afs_CacheStoreProc
Felix Frank [Tue, 14 Jul 2009 10:02:19 +0000]
Limited the scope of some local variables in afs_CacheStoreProc

Reviewed-on: http://gerrit.openafs.org/119
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>

12 years agoOpen/close connections in afs_fetchstore rather than afs_segments
Felix Frank [Tue, 14 Jul 2009 09:19:31 +0000]
Open/close connections in afs_fetchstore rather than afs_segments

The respective snippets are moved from afs_StoreAllSegments to
rxfs_storeDestroy and rxfs_storeInit respectively. This makes sense
and enhances readability.

Reviewed-on: http://gerrit.openafs.org/118
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>

12 years agoPAG numbers are unsigned (and other warnings)
Simon Wilkinson [Tue, 21 Jul 2009 19:26:34 +0000]
PAG numbers are unsigned (and other warnings)

PAG numbers are represented by afs_uint32. Fix assorted call sites to
reflect this.

While we're here, prototype ktc_newpag, and fix the casts used by
the ktc_curpag() call.

Reviewed-on: http://gerrit.openafs.org/167
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>

12 years agoMake lockIDSet readable by mortals
Simon Wilkinson [Tue, 21 Jul 2009 18:58:16 +0000]
Make lockIDSet readable by mortals

The lockIDSet function was a sprawling mess of #ifdefs. This change
consolidates it so there is completely different function for each
platform, with some internal #ifdefs remaining for platform-specific
variations. The side effect of this is that the function is now readable.

Reviewed-on: http://gerrit.openafs.org/164
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>

12 years agoFix printfs of time for Darwin
Simon Wilkinson [Tue, 21 Jul 2009 19:10:05 +0000]
Fix printfs of time for Darwin

Darwin uses a fancy type for tv_sec, which needs to be cast to long
before it can be printed.

Reviewed-on: http://gerrit.openafs.org/165
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>

12 years agoMove statistics and and call-closing from afs_segments to afs_fetchstore.
Felix Frank [Tue, 14 Jul 2009 09:07:07 +0000]
Move statistics and and call-closing from afs_segments to afs_fetchstore.

Rather than in afs_StoreAllSegments, do statistics in afs_CacheStoreProc,
further boosting the former's readability. Calls are closed in a new
storeOp now, rxfs_storeClose, and have been moved there from
afs_StoreAllSegments as well.

Reviewed-on: http://gerrit.openafs.org/117
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Russ Allbery <rra@stanford.edu>

12 years agoWindows: Correct buf_Write data loss errors
Jeffrey Altman [Thu, 20 Aug 2009 21:22:08 +0000]
Windows: Correct buf_Write data loss errors

buf_Write has two errors in it.  First, if offset at which the
write is supposed to begin does not align with the cm_data.blockSize,
then (offset %blockSize) octets at the end of the write will fail
to be written to the file server.   Second, if there is no knowledge
of the file server's ability to handle RXAFS_StoreData64 calls
and the file server does not support StoreData64 calls, then the
first chunkSize of data will be written to the file server before
the RXGEN_OPCODE error is detected.  In this case a retry using
RXAFS_StoreData is performed but the values of 'nbytes' and 'qdp'
were not reset before the retry.  As a result, the first chunkSize
of data would fail to be written to the file server.

The second problem can reliably occur when connectivity between the
cache manager and the file server is interrupted due to firewall
port mapping closures.  Upon establishing a new rx connection, a
SRXAFSCB_InitCallBackState3 RPC will be issued by the file server
erasing any prior knowledge of the file server's ability to process
64-bit data operations.  If the first 64-bit operation is a
StoreData64, then data loss will occur.

LICENSE MIT

FIXES 125220
FIXES 108199

Reviewed-on: http://gerrit.openafs.org/332
Tested-by: Asanka Herath <asanka@secure-endpoints.com>
Reviewed-by: Asanka Herath <asanka@secure-endpoints.com>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: cleanup smb polution of non-smb modules
Jeffrey Altman [Thu, 20 Aug 2009 14:54:47 +0000]
Windows: cleanup smb polution of non-smb modules

There are a variety of functions that are declared in smb modules
that are used within non-smb modules.   In order to reduce some of
the polution, several time conversion functions and the thread
priority operations are migrated to cm_utils.  As part of this
migration the unused !USE_NUMERIC_TIME_CONV time implementations
are removed.

In addition, an unnecessary use of an SMB preprocessor symbols
is removed from cm_freelance.c and smb_ioctls.h is no longer
included within afsd.h.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/330
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: Init root.afs before smb_Init
Jeffrey Altman [Thu, 20 Aug 2009 18:30:27 +0000]
Windows: Init root.afs before smb_Init

It is not safe to initialize the root.afs cm_scache object
after the SMB package.  Break it out of afsd_InitDaemon()
into its own afsd_InitRoot() and call from afsd_InitCM().

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/331
Tested-by: Asanka Herath <asanka@secure-endpoints.com>
Reviewed-by: Asanka Herath <asanka@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoDescribe 's' PTS group permissions more accurately
Russ Allbery [Wed, 19 Aug 2009 23:07:27 +0000]
Describe 's' PTS group permissions more accurately

PTS groups with 's' access permissions can be examined by members of the
group and the owner of the group in addition to system:administrators.
State this in the manual page.

Reviewed-on: http://gerrit.openafs.org/327
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoWindows: Ensure consistency of error code mapping
Jeffrey Altman [Thu, 20 Aug 2009 13:21:53 +0000]
Windows: Ensure consistency of error code mapping

For Windows, the error mapping table used throughout the system
is located in util/errmap_nt.h.   This table was incomplete and
WINNT/afsd/cm_utils.c added additional mapping locally.  Move
said error mapping to util/errmap_nt.h.

When including afs/unified_afs.h it must be done after including
afs/errmap_nt.h.   Otherwise, undefined errors are mapped to EIO
which should not be.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/328
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: Add prototype for osi_SetLockOrderValidation
Jeffrey Altman [Thu, 20 Aug 2009 13:44:18 +0000]
Windows: Add prototype for osi_SetLockOrderValidation

Add prototype for osi_SetLockOrderValidation() defined
in osibasel.c

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/329
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoMove context of afs_CacheStoreProc() call from afs_segments to afs_fetchstore
Felix Frank [Tue, 14 Jul 2009 09:01:57 +0000]
Move context of afs_CacheStoreProc() call from afs_segments to afs_fetchstore

The innermost loop in afs_StoreAllSegments (looping over chunks) is now
inlined in afs_CachStoreProc. This is step one in a series of such
inlinings.

Reviewed-on: http://gerrit.openafs.org/116
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>

12 years agoMove statistics keeping from afs_dcache to afs_fetchstore.
Felix Frank [Tue, 14 Jul 2009 08:57:21 +0000]
Move statistics keeping from afs_dcache to afs_fetchstore.

More context of the afs_CacheFetchProc() call in GetDCache is now inlined
in the afs_CacheFetchProc. Boosts readability of GetDCache and saves
stack, as counter pointers need not be passed anymore. The statistics
code is more readable due to lesser indentation.

Reviewed-on: http://gerrit.openafs.org/115
Reviewed-by: Russ Allbery <rra@stanford.edu>
Tested-by: Russ Allbery <rra@stanford.edu>

12 years agoWindows: cm_conn_t must not be referenced after cm_Analyze is called
Jeffrey Altman [Wed, 19 Aug 2009 22:10:43 +0000]
Windows: cm_conn_t must not be referenced after cm_Analyze is called

The 64-bit Large File Support added a reference to the cm_conn_t
object after cm_Analyze() is called and releases the hold.  This
permits the object to be freed if it is appropriate to do so
which can result in an invalid memory reference.

This change removes the improper reference.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/326
Tested-by: Asanka Herath <asanka@secure-endpoints.com>
Reviewed-by: Asanka Herath <asanka@secure-endpoints.com>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoSome code cleanups and variable renames.
Felix Frank [Tue, 14 Jul 2009 08:54:06 +0000]
Some code cleanups and variable renames.

Reviewed-on: http://gerrit.openafs.org/113
Tested-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Russ Allbery <rra@stanford.edu>

12 years agoWindows: Permit build system to update symbol store
Jeffrey Altman [Wed, 19 Aug 2009 12:04:30 +0000]
Windows: Permit build system to update symbol store

Microsoft Debugging Tools for Windows, Visual Studio Debugger,
and SysInternals tools can all make use of a Symbol Server.
  http://msdn.microsoft.com/en-us/magazine/cc163563.aspx
The commit adds functionality to the build system to automatically
add binaries and symbols to a symbol store during the build.
This functionality is only enabled if two environment variables
are defined:

  SYMSTORE_EXE  - specifies the location of symstore.exe
  SYMSTORE_ROOT - specifies the location of the symbol store

an optional environment variable permits an arbitrary comment
to be added to the symbol store history file.

  SYMSTORE_COMMENT - arbitrary text to be added to the history

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/324
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: Add resource info to threaded volserver.exe
Jeffrey Altman [Wed, 19 Aug 2009 15:51:18 +0000]
Windows: Add resource info to threaded volserver.exe

1.5.60 and 1.5.61 shipped without resource information
linked to the threaded version of the volserver.exe
executable.  Correct that oversight.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/325
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoMake MacOS installer pane permit dashes
Simon Wilkinson [Tue, 18 Aug 2009 21:31:38 +0000]
Make MacOS installer pane permit dashes

The MacOS installer only permits characters in [0-9A-Za-z] in cellnames.
However, OpenAFS itself will also allow dashes, and they're in use by some
sites.

This trivially amends the installer pane to permit dashes.

FIXES 125211

Reviewed-on: http://gerrit.openafs.org/323
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoFix stack corruption on 64 bit linux when md5inum is enabled
Michael Meffie [Tue, 18 Aug 2009 18:51:57 +0000]
Fix stack corruption on 64 bit linux when md5inum is enabled

Fix a stack overflow on 64 bit linux which corrupts the stack
saved arguments and causes a kernel panic. This bug is seen
on platforms where ino_t is 64 bits and the md5inum sysctl
option is enabled.

Reviewed-on: http://gerrit.openafs.org/322
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoWindows: Be more conservative about checking error conditions
Jeffrey Altman [Mon, 17 Aug 2009 16:33:09 +0000]
Windows: Be more conservative about checking error conditions

It has been reported that winlogon.exe is crashing on some
systems.  The reports indicate that the failure is somewhere
in GetLogonDomainOptions.  This commit ensures that we are
more conservative about the assumptions that are made regarding
which Lsa operations can fail.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/321
Reviewed-by: Asanka Herath <asanka@secure-endpoints.com>
Tested-by: Asanka Herath <asanka@secure-endpoints.com>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: src/WINNT/afsd cleanup
Jeffrey Altman [Mon, 17 Aug 2009 21:28:28 +0000]
Windows: src/WINNT/afsd cleanup

Update the "clean" rule to remove the files generated from
ms-srvsvc.idl and ms-wkssvc.idl.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/320
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: Prevent smb_StartedLock use before initialization
Jeffrey Altman [Sun, 16 Aug 2009 12:43:23 +0000]
Windows: Prevent smb_StartedLock use before initialization

The smb_StartedLock osi_mutex can be obtained before
initialization due to a race if the IP address configuration
is in a state of flux as afsd_service is starting up.
To avoid the problem call cm_InitDaemons() after smb_Init().

This race is the cause of the periodic assertions in some
environments when lock order validation is enabled.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/318
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: Add missing msrpc.h dependency
Jeffrey Altman [Sat, 15 Aug 2009 10:43:57 +0000]
Windows: Add missing msrpc.h dependency

msrpc.h must include cm_nls.h

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/316
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Asanka Herath <asanka@secure-endpoints.com>
Tested-by: Asanka Herath <asanka@secure-endpoints.com>

12 years agoWindows: Prevent cm_daemon thread from terminating during suspend
Jeffrey Altman [Sat, 15 Aug 2009 01:40:22 +0000]
Windows: Prevent cm_daemon thread from terminating during suspend

Remove the check for powerStateSuspend that caused the cm_daemon
thread to terminate when the machine enters suspend mode.  When
the machine awakens there is no thread to check the down server
state, new IP address bindings, etc.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/315
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoMove context of CacheFetchProc from afs_dcache.c to afs_fetchstore.c
Felix Frank [Tue, 14 Jul 2009 08:51:03 +0000]
Move context of CacheFetchProc from afs_dcache.c to afs_fetchstore.c

GetDCache() is quite bloated. This inlinining makes code more
readable. For protocols to come besides rxfs (such as rxosd), some
initializations may need to be performed differently. Thus, much
has to be moved to the specific rxfs_fetchInit() function rather than
afs_CacheFetchProc() proper.

Reviewed-on: http://gerrit.openafs.org/112
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agomacos 10.6 updates
Derrick Brashear [Fri, 14 Aug 2009 16:06:03 +0000]
macos 10.6 updates

cope with mixed 32/64 environment provided by macos 10.6. build needed
stuff for audit logs in shlibafsauthent.

Reviewed-on: http://gerrit.openafs.org/310
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoOSX Preference Pane and AFS Backgrounder
Claudio Bisegni [Wed, 12 Aug 2009 19:19:49 +0000]
OSX Preference Pane and AFS Backgrounder

Cleaned most unused log

Reviewed-on: http://gerrit.openafs.org/308
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoFix gtx_create calls to all share a prototype
Simon Wilkinson [Wed, 22 Jul 2009 22:05:48 +0000]
Fix gtx_create calls to all share a prototype

All of the different _create calls need to share a prototype, so
function pointers can be stuffed into a structure. Use an anonymous
pointer so that we can acheive this.

Reviewed-on: http://gerrit.openafs.org/187
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoHandle more RPC service names
Asanka Herath [Wed, 12 Aug 2009 18:56:56 +0000]
Handle more RPC service names

While the Windows client only implements support for WKSSVC and
SRVSVC RPC services, it should be aware of and handle requests
for other well known service names.

This patch refactors service name checks to a separate
MSRPC_IsWellKnownService() function.  In addition, it separates
the tests for IPC TIDs from the test for well known service
names.  An IPC TID may be used for generic pipe operations as
well as for RPC message pipe operations.  Therefore the fact that
a TID was opened for IPC doesn't necessarily mean that it will
only be used for RPC.

Reviewed-on: http://gerrit.openafs.org/307
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agorand_s isn't supported on older Visual C compilers
Asanka Herath [Wed, 12 Aug 2009 17:57:11 +0000]
rand_s isn't supported on older Visual C compilers

We still support building on Visual Studio 2003 where rand_s() is
not available.  If we are building on a Visual C compiler prior
to version 15.00, failover to srand()/rand() instead of using
rand_s().

Reviewed-on: http://gerrit.openafs.org/306
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoRemove CacheStoreProcs and CacheFetchProcs from the afs_cacheOps.
Felix Frank [Thu, 2 Jul 2009 09:12:24 +0000]
Remove CacheStoreProcs and CacheFetchProcs from the afs_cacheOps.

The entries are no longer used, as the macros from afs_chunkops.h
are no longer necessary and afs_StoreAllSegments calls the
CacheStoreProc proper.

Reviewed-on: http://gerrit.openafs.org/110
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoOSX AFSBackgrounder fix minor bug
Claudio Bisegni [Wed, 12 Aug 2009 10:41:42 +0000]
OSX AFSBackgrounder fix minor bug

Has been fixed the status menu icon width, now i keeped from icon image.
Fixed the status item icon view redraw.

Reviewed-on: http://gerrit.openafs.org/305
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoWindows: Dfs Referrals Processing. Not all errors are errors.
Jeffrey Altman [Tue, 11 Aug 2009 14:37:19 +0000]
Windows: Dfs Referrals Processing.  Not all errors are errors.

When processing a Dfs Referral request, not all lookup errors
should be treated as if the path does not exist.  Servers being
down or busy, volumes offline, cell vldb servers not found, etc.
do not mean that the client should go searching elsewhere to
evaluate the path.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/304
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: Avoid unnecessary DNS lookups
Jeffrey Altman [Tue, 11 Aug 2009 12:43:53 +0000]
Windows: Avoid unnecessary DNS lookups

Windows will attempt to open connections to a broad
range of pipe service (share) names which do not contain
a dot in them.  Attempts to search for these names as
cell names in DNS result in timeouts and sluggish behavior
when browsing \\AFS in the Explorer Shell.

To avoid this problem, do not perform a DNS lookup for a
cellname that doesn't not contain a dot in it.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/302
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: Setting Server Preferences
Jeffrey Altman [Tue, 11 Aug 2009 12:59:39 +0000]
Windows: Setting Server Preferences

The Windows cache manager can apply administrator specified
server preferences as specified in the registry.   When these
rankings are applied the CM_SERVERFLAG_PREF_SET flag was not
set on the cm_server_t object.  In addition, appropriate locking
was not being used in the places where the flag was set.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/303
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoUnite CacheFetchProcs and add abstraction calls.
Felix Frank [Thu, 2 Jul 2009 07:14:13 +0000]
Unite CacheFetchProcs and add abstraction calls.

The cache type specific differencies among afs_MemCacheFetchProc
and afs_UFSCacheFetchProc are divided into two sets of "fetchOps".
Upon rxfs_fetchInit, the appropriate set is chosen.

Reviewed-on: http://gerrit.openafs.org/109
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoWindows: Implement SRVSVC and WKSSVC RPC interfaces
Asanka Herath [Fri, 7 Aug 2009 02:56:42 +0000]
Windows: Implement SRVSVC and WKSSVC RPC interfaces

Windows uses RPC over SMB to communicate with file servers for
administrative tasks including enumeration and queries of file
server shares.  This patch implements support for RPC over SMB
and partially implements the SRVSVC and WKSSVC RPC interfaces.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/301
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoRestore util des dependency
Andrew Deason [Mon, 10 Aug 2009 17:06:26 +0000]
Restore util des dependency

Commit c3c8a3e2f912855addc2c430f909bdce912e3670 removed 'des' as a
dependency of the 'util' target, but util still depends on des since
rxkstats.c includes des.h. So, put the des dep back in.

Reviewed-on: http://gerrit.openafs.org/278
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoMCAS changes from Matt
matt@linuxbox.com [Sat, 25 Jul 2009 18:10:25 +0000]
MCAS changes from Matt

Change static max allocators to 30.  Add atomic add/sub macros returning
original value, based on CASIO.  Add interfaces to add and remove generic
allocator caches.  Add atomic inc/dec/sub macros using MCAS primitives.
Add inline assembly for x86_64 and shim for Solaris (9+) atomic operations,
providing Solaris x86 and alternate shim for Solaris Sparc.  Set interface
adapted for iteration and generalized for use with opaque key, value
pointers.  File cas_skip_func.c provides kv interface, cas_skip_adt.c
provides kv interface, plus iteration on skip lists.  Casual dependencies
on stdio and exit() defined out.

LICENSE BSD

Reviewed-on: http://gerrit.openafs.org/214
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agofileserver should actually retry VL_RegisterAddrs on failure
Derrick Brashear [Mon, 3 Aug 2009 16:17:14 +0000]
fileserver should actually retry VL_RegisterAddrs on failure

currently the background daemon logic for retrying was never triggered.
easy enough fix: set FS_registered to 1 so the loop retries

Reviewed-on: http://gerrit.openafs.org/266
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoadd xdr_alloc
Jeffrey Altman [Sun, 2 Aug 2009 22:59:51 +0000]
add xdr_alloc

applications can allocate memory that must be deallocated by
the XDR package.  Add xdr_alloc to permit that.

Export from libafsrpc.

LICENSE BSD

Reviewed-on: http://gerrit.openafs.org/269
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoMake Windows pioctl prototypes consistent with Unix
Jeffrey Altman [Sat, 1 Aug 2009 16:31:36 +0000]
Make Windows pioctl prototypes consistent with Unix

The Windows pioctl prototypes differed from those now exported
by sys/sys_prototypes.h.  This produced undesirable warnings.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/260
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoWindows: Preserve GetLastError during WinTorture testing
Jeffrey Altman [Thu, 6 Aug 2009 03:25:42 +0000]
Windows: Preserve GetLastError during WinTorture testing

When an error occurs during the WinTorture scripts the
actual error was not always being preserved because
subsequent Win32 calls were executed before the value
was logged.

In at least one case, the variable used to store the
last error was not initialized nor assigned in all data
paths.

LICENSE MIT

Reviewed-on: http://gerrit.openafs.org/270
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agokauth warning reduction
Marc Dionne [Mon, 27 Jul 2009 18:24:15 +0000]
kauth warning reduction

Warning removal for various functions that manipulates keys and use
several data types interchangeably.
Inline helpers are introduced to convert between the types and are
used when making function calls to target the appropriate type:

des_prototypes.h
cblockptr_to_cblock:  des_cblock *  to des_cblock
charptr_to_cblock:  char *  to des_cblock
charptr_to_cblockptr:  char *  to des_cblock *

rxkad_prototypes.h
ktc_to_cblock:  struct ktc_encryptionKey *  to des_cblock
ktc_to_cblockptr:  struct ktc_encryptionKey *  to des_cblock *

kauth_internal.h
EncryptionKey_to_cblock:  EncryptionKey *  to des_cblock
EncryptionKey_to_ktc:  EncryptionKey *  to struct ktc_encryptionKey *
ktc_to_EncryptionKey:  struct ktc_encryptionKey *  to EncryptionKey *

- parameters are adjusted for tkt_DecodeTicket(5), replacing the char *
key with struct ktc_encryptionKey, to match usage
- the get_key function is changed to have a void * parameter, to match
usage
- rxkad_prototypes.h includes des.h to get the des_cblock definition.
This causes conflicts for a few files where the kerberos headers are
also included - aklog/aklog_main.c and WINNT/afsd/afskfw.c
Use NO_DES_H_INCLUDE in thoses cases to skip the new parts of
rxkad_prototypes.h

Reviewed-on: http://gerrit.openafs.org/234
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoRemoved user perspectivev3 file in xcode project and update the gitconfig
Claudio Bisegni [Mon, 3 Aug 2009 17:05:46 +0000]
Removed user perspectivev3 file in xcode project and update the gitconfig

gitconfig in src/platform/DARWIN/AFSPreference has been modified to ignore the perspectivev3 that is created by xcode for window layout.Has been also delete the file created for the user

Reviewed-on: http://gerrit.openafs.org/267
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoCleaned most warning OSX OpenAFS preference and completed the AFSBackgrounder implem...
Claudio Bisegni [Mon, 3 Aug 2009 14:40:05 +0000]
Cleaned most warning OSX OpenAFS preference  and completed the AFSBackgrounder implementation

At startup the preference pane check for the presence in ~/Library/LaunchAgents of the file  it.infn.lnf.network.AFSBackgrounder.plist that. The agent could be started in OpenAFS preference pane view.
AFSBackgrounder has replaced the NSMenuExtra, when it doesn't quit well launchd restart it. AFSBackgrounder can be used also for other work, for now, at login it check the user preference for get token.
Has been made some refactoring in code for remove most warning.
The unused think are been delete from project.

Reviewed-on: http://gerrit.openafs.org/263
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

12 years agoStoreops beautifications.
Felix Frank [Thu, 2 Jul 2009 07:02:50 +0000]
Storeops beautifications.

Things can be made a lot more readable in storeOps than in the
monolithic StoreProc.
Also shorten a panic message that is a bit gratuitous.

Reviewed-on: http://gerrit.openafs.org/108
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoAFS Backgrounder implementation & warirng clean
Claudio Bisegni [Sat, 1 Aug 2009 17:43:39 +0000]
AFS Backgrounder implementation & warirng clean

Replaced the NSMenuExtra and created the AFSBackgrounder that will do all work for aklog at login and manage the Status menu in menu bar

Reviewed-on: http://gerrit.openafs.org/262
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoStart coding OSX Backgrounder Application, for OpenAFS Preference Pane, that user...
Claudio Bisegni [Wed, 29 Jul 2009 13:12:13 +0000]
Start coding OSX Backgrounder Application, for OpenAFS Preference Pane, that user NSStatusItem

To prevent future compatibility with osx we must use NSStatusItem instead NSMenuExtra that is not documented api.
For this has been created a background only application that will manage all function managed by current NSMenuExtra

Reviewed-on: http://gerrit.openafs.org/261
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoAdd generated files to doc/xml/AdminGuide .gitignore
Jeffrey Altman [Sat, 1 Aug 2009 15:23:00 +0000]
Add generated files to doc/xml/AdminGuide .gitignore

Add htmlhelp.hhp, index.hhk, and toc.hhc

Reviewed-on: http://gerrit.openafs.org/259
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

12 years agoversion update for 1.5.61 openafs-devel-1_5_61
Derrick Brashear [Fri, 31 Jul 2009 21:53:18 +0000]
version update for 1.5.61

make configure version strings be 1.5.61

Reviewed-on: http://gerrit.openafs.org/258
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

12 years agoRestore permission documentation in bosserver man page
Russ Allbery [Fri, 24 Jul 2009 20:03:48 +0000]
Restore permission documentation in bosserver man page

The original IBM HTML documentation had a table showing the permissions
that bosserver expects and sets when it creates the directory structure
for AFS.  That table was accidentally dropped in the conversion to POD.
Restore it from the HTML shipped with an older version of OpenAFS.

Reviewed-on: http://gerrit.openafs.org/210
Tested-by: Russ Allbery <rra@stanford.edu>
Reviewed-by: Russ Allbery <rra@stanford.edu>