Clean up assertion
authorSimon Wilkinson <sxw@your-file-system.com>
Sun, 10 Jul 2011 12:46:11 +0000 (13:46 +0100)
committerDerrick Brashear <shadow@dementix.org>
Mon, 26 Sep 2011 04:10:11 +0000 (21:10 -0700)
commitcac74242728ad97e3ce9cef0a949d58c237250f6
treecfcf278ee3f65928b9b2b0acb9800efc4e006dd6
parent0a8f21e6a44d59a3333c0b4fee572fe6d94aae3d
Clean up assertion

The AFS code has multiple different assertion implementations in
userspace. This patchset is the start of bringing some sanity to them.

In rx, we have osi_Assert, a user/kernel assertion macro. This is only
available to libraries which have RX dependencies

In util, we redefine the standard 'assert()' macro to provide a
cross-platform assertion solution.

Because util has an RX dependency, neither of these provide an
assertion solution for libraries which should be independent of rx.
So, pull the assertion code out of util, and put it into opr, as a new
opr_Assert() macro. Implement the userspace osi_Assert in terms of this
macro, leaving the kernel variant untouched.

Update callers to the new macro and header file names.

Change-Id: I780b30ec1ea1207daa17127df4d5fbf9a94481b6
Reviewed-on: http://gerrit.openafs.org/5394
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
87 files changed:
src/WINNT/afsd/fs.c
src/WINNT/afsd/fs_acl.c
src/WINNT/afsd/fs_utils.c
src/afs/UKERNEL/sysincludes.h
src/afsd/afsd.c
src/bu_utils/Makefile.in
src/butc/Makefile.in
src/butc/tcmain.c
src/butc/tcprocs.c
src/butc/tcudbprocs.c
src/dviced/Makefile.in
src/dvolser/Makefile.in
src/gtx/Makefile.in
src/kauth/admin_tools.c
src/libadmin/client/NTMakefile
src/libafsrpc/Makefile.in
src/libuafs/Makefile.common.in
src/lwp/lock.c
src/lwp/lock.h
src/opr/Makefile.in
src/opr/NTMakefile
src/opr/assert.c
src/opr/opr.h
src/opr/opr_assert.h [new file with mode: 0644]
src/shlibafsrpc/Makefile.in
src/shlibafsrpc/libafsrpc.map
src/tbudb/Makefile.in
src/tptserver/Makefile.in
src/tsalvaged/Makefile.in
src/tsalvaged/salvsync-debug.c
src/tubik/Makefile.in
src/tviced/Makefile.in
src/tviced/serialize_state.c
src/tviced/state_analyzer.c
src/tvlserver/Makefile.in
src/tvolser/Makefile.in
src/ubik/remote.c
src/ubik/ubik.p.h
src/ubik/ubikclient.c
src/usd/usd_file.c
src/util/Makefile.in
src/util/NTMakefile
src/util/afs_assert.h [deleted file]
src/util/afsutil_prototypes.h
src/util/assert.c [deleted file]
src/util/dirpath.c
src/util/ktime.c
src/util/netutils.c
src/util/pthread_glock.h
src/util/pthread_nosigs.h
src/util/serverLog.c
src/util/softsig.c
src/venus/fs.c
src/viced/afsfileprocs.c
src/viced/callback.c
src/viced/host.c
src/viced/host.h
src/viced/physio.c
src/viced/viced.c
src/viced/viced.h
src/vol/clone.c
src/vol/daemon_com.c
src/vol/fssync-client.c
src/vol/fssync-debug.c
src/vol/ihandle.c
src/vol/namei_ops.c
src/vol/ntops.c
src/vol/nuke.c
src/vol/partition.c
src/vol/purge.c
src/vol/salvaged.c
src/vol/salvager.c
src/vol/salvsync-server.c
src/vol/vg_cache.c
src/vol/vg_scan.c
src/vol/vnode.c
src/vol/vol-salvage.c
src/vol/volume.c
src/vol/volume_inline.h
src/vol/vutil.c
src/volser/dumpstuff.c
src/volser/physio.c
src/volser/vol_split.c
src/volser/volmain.c
src/volser/volprocs.c
src/volser/volser.p.h
src/volser/voltrans.c