From 1409bf8e007ac1060dfaf8ec09bdc27e95db3ba9 Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Sun, 28 Jun 2015 13:59:28 -0400 Subject: [PATCH 1/1] Windows: cm_CheckNTDelete missing SyncDone call cm_CheckNTDelete() forgot to call cm_SyncDone() in one of the error paths. Fixup the call pattern and do not forget to call cm_SyncDone(). Change-Id: I9274b65c5a5f22ca71e0b10f860d57d7e567a56c Reviewed-on: http://gerrit.openafs.org/11917 Tested-by: BuildBot Reviewed-by: Jeffrey Altman --- src/WINNT/afsd/cm_vnodeops.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/WINNT/afsd/cm_vnodeops.c b/src/WINNT/afsd/cm_vnodeops.c index b73f90b..f1f691b 100644 --- a/src/WINNT/afsd/cm_vnodeops.c +++ b/src/WINNT/afsd/cm_vnodeops.c @@ -375,8 +375,10 @@ long cm_CheckNTDelete(cm_scache_t *dscp, cm_scache_t *scp, cm_user_t *userp, if (code) goto done; - if (cm_HaveBuffer(scp, bufferp, 1)) + if (cm_HaveBuffer(scp, bufferp, 1)) { + cm_SyncOpDone(scp, bufferp, CM_SCACHESYNC_NEEDCALLBACK | CM_SCACHESYNC_READ | CM_SCACHESYNC_BUFLOCKED); break; + } /* otherwise, load the buffer and try again */ lock_ReleaseMutex(&bufferp->mx); -- 1.9.4