From 2d8045d67686fbb80696b47b4a60e48e7e74fec9 Mon Sep 17 00:00:00 2001 From: Mark Vitale Date: Tue, 11 Sep 2018 15:59:41 -0400 Subject: [PATCH] budb: SBUDB_FindLatestDump should check result of FillDumpEntry FillDumpEntry may return an error, but FindLatestDump doesn't check its result. Therefore, SBUDB_FindLatestDump may return invalid results. Instead, check the return code from FillDumpEntry and abort the call if it fails. Change-Id: If0b44ba2a12a76511129d77110ef669b00780ff0 Reviewed-on: https://gerrit.openafs.org/13312 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk --- src/budb/procs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/budb/procs.c b/src/budb/procs.c index f976ff3..cf35576 100644 --- a/src/budb/procs.c +++ b/src/budb/procs.c @@ -2230,7 +2230,9 @@ FindLatestDump(struct rx_call *call, char *vsname, char *dumpPath, finished: /* return the dump found */ - FillDumpEntry(ut, retdbaddr, dumpentry); + eval = FillDumpEntry(ut, retdbaddr, dumpentry); + if (eval) + ABORT(eval); code = ubik_EndTrans(ut); return (code); -- 1.9.4