From 307856353c3f168105ce82f3f3fa8e4c5efb0b6c Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Fri, 16 Dec 2011 18:24:50 -0500 Subject: [PATCH] Windows: log volume and authgroup for redir open If opening a volume root fails, log the authgroup and volume to make it easier to debug the error. Change-Id: I0c9ffc58ffaf7582a1b22043de2b5d096530de5b Reviewed-on: http://gerrit.openafs.org/6352 Tested-by: BuildBot Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman --- src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp b/src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp index c534890..13554ae 100644 --- a/src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp +++ b/src/WINNT/afsrdr/kernel/lib/AFSCreate.cpp @@ -926,7 +926,9 @@ AFSCommonCreate( IN PDEVICE_OBJECT DeviceObject, AFSDbgLogMsg( AFS_SUBSYSTEM_FILE_PROCESSING, AFS_TRACE_LEVEL_ERROR, - "AFSCommonCreate Failed to open root (2) Status %08lX\n", + "AFSCommonCreate Failed to open volume root %08lX-%08lX Status %08lX\n", + pVolumeCB->ObjectInformation.FileId.Cell, + pVolumeCB->ObjectInformation.FileId.Volume, ntStatus); InterlockedDecrement( &pDirectoryCB->OpenReferenceCount); @@ -1465,12 +1467,32 @@ AFSOpenRoot( IN PIRP Irp, if( !NT_SUCCESS( ntStatus)) { + UNICODE_STRING uniGUID; + + uniGUID.Length = 0; + uniGUID.MaximumLength = 0; + uniGUID.Buffer = NULL; + + if( AuthGroup != NULL) + { + RtlStringFromGUID( *AuthGroup, + &uniGUID); + } + AFSDbgLogMsg( AFS_SUBSYSTEM_FILE_PROCESSING, AFS_TRACE_LEVEL_ERROR, - "AFSOpenRoot (%08lX) Failed open in service AFSRoot Status %08lX\n", + "AFSOpenRoot (%08lX) Failed open in service volume %08lX-%08lX AuthGroup %wZ Status %08lX\n", Irp, + VolumeCB->ObjectInformation.FileId.Cell, + VolumeCB->ObjectInformation.FileId.Volume, + &uniGUID, ntStatus); + if( AuthGroup != NULL) + { + RtlFreeUnicodeString( &uniGUID); + } + try_return( ntStatus); } -- 1.9.4