From 3f0b9907d12c00725548dbaf84fee3e033cb974c Mon Sep 17 00:00:00 2001 From: Pat Riehecky Date: Tue, 12 Jun 2018 13:55:56 -0500 Subject: [PATCH] afs: test condition mismatch resolved While it is unexpected, it is possible for the two disconnected flags to get out of sync resulting in a path to an undefined varible in use. (via cppcheck) Change-Id: I995b402e73c2c330485050dd2594a62fe67d1bca Reviewed-on: https://gerrit.openafs.org/13207 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk --- src/afs/VNOPS/afs_vnop_create.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/afs/VNOPS/afs_vnop_create.c b/src/afs/VNOPS/afs_vnop_create.c index fe37eed..c4d7c70 100644 --- a/src/afs/VNOPS/afs_vnop_create.c +++ b/src/afs/VNOPS/afs_vnop_create.c @@ -451,7 +451,7 @@ afs_create(OSI_VC_DECL(adp), char *aname, struct vattr *attrs, if (origCBs == finalCBs && origZaps == finalZaps) { tvc->f.states |= CStatd; /* we've fake entire thing, so don't stat */ tvc->f.states &= ~CBulkFetching; - if (!AFS_IS_DISCON_RW) { + if (!AFS_IS_DISCONNECTED && !AFS_IS_DISCON_RW) { tvc->cbExpires = CallBack.ExpirationTime; afs_QueueCallback(tvc, CBHash(CallBack.ExpirationTime), volp); } -- 1.9.4