From 51d31209dc9a3082461cc9430da0975fdf28b085 Mon Sep 17 00:00:00 2001 From: Benjamin Kaduk Date: Fri, 10 Jan 2014 00:00:52 -0500 Subject: [PATCH 1/1] Use an explicit symbol for uninitialized vnode types Avoid trying to get clever with stuffing -1 into an unsigned bitfield, which causes the value to change and generates a warning from clang. Just use vNull, which is intended to be used for uninitialized/empty vnodes. Change-Id: I5662887e5a68c7e687025d19226f821d8f2d6a09 Reviewed-on: http://gerrit.openafs.org/10701 Tested-by: BuildBot Reviewed-by: Derrick Brashear --- src/tools/dumpscan/dumptool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/tools/dumpscan/dumptool.c b/src/tools/dumpscan/dumptool.c index be8d575..70b2ec7 100644 --- a/src/tools/dumpscan/dumptool.c +++ b/src/tools/dumpscan/dumptool.c @@ -918,7 +918,7 @@ ScanVnodes(FILE * f, VolumeDiskData * vol, int sizescan) offset = 0; length = 0; - vnode->type = -1; + vnode->type = vNull; vnode->length = -1; if (ReadInt32(f, (uint32_t *) & vnodeNumber)) { @@ -1064,7 +1064,7 @@ ScanVnodes(FILE * f, VolumeDiskData * vol, int sizescan) * just skip it (because we can't do anything with it. */ - if (vnode->type == -1) + if (vnode->type == vNull) continue; #ifdef RESIDENCY -- 1.9.4