From 581ec9f06a8958637db33d14f8d0e24d841d5eff Mon Sep 17 00:00:00 2001
From: Marc Dionne <marc.c.dionne@gmail.com>
Date: Mon, 27 Jul 2009 11:29:34 -0400
Subject: [PATCH] Eliminate some "implicit function declaration" warnings

Include appropriate header files to eliminate some warnings for
implicit function declarations.  These are simple cases that don't
generate new warnings because of the prototypes.
Use grp.h if it exists to get setgroups() definition.

Reviewed-on: http://gerrit.openafs.org/233
Tested-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
---
 acinclude.m4                          | 2 +-
 src/budb/struct_ops.c                 | 1 +
 src/kauth/kkids.c                     | 1 +
 src/kauth/knfs.c                      | 1 +
 src/kauth/user.c                      | 1 +
 src/libadmin/client/afs_clientAdmin.c | 1 +
 src/sys/pioctl.c                      | 4 ++++
 src/sys/rmtsysc.c                     | 3 +++
 src/sys/setpag.c                      | 1 +
 src/uss/grammar.y                     | 4 ++++
 src/venus/test/getinitparams.c        | 1 +
 src/venus/up.c                        | 1 +
 src/vol/fssync-debug.c                | 1 +
 src/vol/salvager.c                    | 1 +
 src/vol/vol-info.c                    | 1 +
 src/vol/vol-salvage.c                 | 1 +
 src/volser/vol_split.c                | 1 +
 src/volser/volmain.c                  | 1 +
 18 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/acinclude.m4 b/acinclude.m4
index 0ec466f..15ecd8b 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -1546,7 +1546,7 @@ dnl checks for header files.
 AC_HEADER_STDC
 AC_HEADER_SYS_WAIT
 AC_HEADER_DIRENT
-AC_CHECK_HEADERS(stdlib.h string.h unistd.h poll.h fcntl.h sys/time.h sys/file.h)
+AC_CHECK_HEADERS(stdlib.h string.h unistd.h poll.h fcntl.h sys/time.h sys/file.h grp.h)
 AC_CHECK_HEADERS(netinet/in.h netdb.h sys/fcntl.h sys/mnttab.h sys/mntent.h)
 AC_CHECK_HEADERS(mntent.h sys/vfs.h sys/param.h sys/fs_types.h sys/fstyp.h)
 AC_CHECK_HEADERS(sys/mount.h strings.h termios.h signal.h poll.h sys/pag.h)
diff --git a/src/budb/struct_ops.c b/src/budb/struct_ops.c
index 9a5c4ff..0894614 100644
--- a/src/budb/struct_ops.c
+++ b/src/budb/struct_ops.c
@@ -21,6 +21,7 @@
 #include <sys/types.h>
 #include <afs/stds.h>
 #include <afs/bubasics.h>
+#include <afs/afsutil.h>
 #include <rx/xdr.h>
 #include <rx/rx.h>
 #include <string.h>
diff --git a/src/kauth/kkids.c b/src/kauth/kkids.c
index 6c5f140..295ebbd 100644
--- a/src/kauth/kkids.c
+++ b/src/kauth/kkids.c
@@ -34,6 +34,7 @@
 #include <afs/prs_fs.h>
 #include <stdlib.h>
 #include <string.h>
+#include <afs/sys_prototypes.h>
 
 #include "kkids.h"
 
diff --git a/src/kauth/knfs.c b/src/kauth/knfs.c
index b87740c..e48c1f0 100644
--- a/src/kauth/knfs.c
+++ b/src/kauth/knfs.c
@@ -30,6 +30,7 @@
 #include <afs/cmd.h>
 #include <afs/auth.h>
 #include <afs/afsutil.h>
+#include <afs/sys_prototypes.h>
 
 /*
 Modifications:
diff --git a/src/kauth/user.c b/src/kauth/user.c
index 7245966..ec82f62 100644
--- a/src/kauth/user.c
+++ b/src/kauth/user.c
@@ -52,6 +52,7 @@
 #include <afs/ptuser.h>
 #include <afs/ptserver.h>
 #include <afs/afsutil.h>
+#include <afs/sys_prototypes.h>
 #include <rx/rx.h>
 #include <rx/rx_globals.h>
 #include <rx/rxkad.h>		/* max ticket lifetime */
diff --git a/src/libadmin/client/afs_clientAdmin.c b/src/libadmin/client/afs_clientAdmin.c
index 38e864d..55f4e77 100644
--- a/src/libadmin/client/afs_clientAdmin.c
+++ b/src/libadmin/client/afs_clientAdmin.c
@@ -46,6 +46,7 @@
 #include <afs/ptserver.h>
 #include <afs/vlserver.h>
 #include <afs/pthread_glock.h>
+#include <afs/sys_prototypes.h>
 
 /*
  * AFS client administration functions.
diff --git a/src/sys/pioctl.c b/src/sys/pioctl.c
index b1d64e5..b65210b 100644
--- a/src/sys/pioctl.c
+++ b/src/sys/pioctl.c
@@ -24,7 +24,11 @@
 #else
 #include <stdio.h>
 #endif
+#if defined(HAVE_UNISTD_H)
+#include <unistd.h>
+#endif
 #include "afssyscalls.h"
+#include "sys_prototypes.h"
 
 #ifdef AFS_AIX32_ENV
 /*
diff --git a/src/sys/rmtsysc.c b/src/sys/rmtsysc.c
index aa534ab..f92fe69 100644
--- a/src/sys/rmtsysc.c
+++ b/src/sys/rmtsysc.c
@@ -34,6 +34,9 @@
 #ifdef HAVE_UNISTD_H
 #include <unistd.h>
 #endif
+#ifdef HAVE_GRP_H
+#include <grp.h>
+#endif
 #include <rx/xdr.h>
 #include "rmtsys.h"
 #include "sys_prototypes.h"
diff --git a/src/sys/setpag.c b/src/sys/setpag.c
index e1d4f4f..3d634f1 100644
--- a/src/sys/setpag.c
+++ b/src/sys/setpag.c
@@ -17,6 +17,7 @@
 
 
 #include <afs/afs_args.h>
+#include <afs/sys_prototypes.h>
 #include <unistd.h>
 #include <stdio.h>
 #if !defined(AFS_AIX_ENV) && !defined(AFS_NT40_ENV) 
diff --git a/src/uss/grammar.y b/src/uss/grammar.y
index 2c3fede..7abb30c 100644
--- a/src/uss/grammar.y
+++ b/src/uss/grammar.y
@@ -15,6 +15,10 @@
 
 extern int line;
 extern int uss_perr;
+
+extern int yylex(void);
+extern int yyerror(char *);
+
 %}
 
 %union
diff --git a/src/venus/test/getinitparams.c b/src/venus/test/getinitparams.c
index 133f422..16eb9a5 100644
--- a/src/venus/test/getinitparams.c
+++ b/src/venus/test/getinitparams.c
@@ -18,6 +18,7 @@
 #include <afs/vice.h>
 #include <afs/venus.h>
 #include <afs/cmd.h>
+#include <afs/sys_prototypes.h>
 #include <fcntl.h>
 #include <unistd.h>
 #ifdef AFS_AIX41_ENV
diff --git a/src/venus/up.c b/src/venus/up.c
index 7d9d11e..1cc7e73 100644
--- a/src/venus/up.c
+++ b/src/venus/up.c
@@ -46,6 +46,7 @@
 
 #include <afs/venus.h>
 #include <afs/sys_prototypes.h>
+#include <afs/afsutil.h>
 
 /* ************************************************************* */
 
diff --git a/src/vol/fssync-debug.c b/src/vol/fssync-debug.c
index f8436e8..b48de7b 100644
--- a/src/vol/fssync-debug.c
+++ b/src/vol/fssync-debug.c
@@ -48,6 +48,7 @@
 #endif
 
 #include <afs/cmd.h>
+#include <afs/dir.h>
 #include <afs/afsutil.h>
 #include <afs/fileutil.h>
 
diff --git a/src/vol/salvager.c b/src/vol/salvager.c
index 8536aab..f62abdb 100644
--- a/src/vol/salvager.c
+++ b/src/vol/salvager.c
@@ -98,6 +98,7 @@
 #include <afs/osi_inode.h>
 #endif
 #include <afs/cmd.h>
+#include <afs/dir.h>
 #include <afs/afsutil.h>
 #include <afs/fileutil.h>
 #include <afs/procmgmt.h>	/* signal(), kill(), wait(), etc. */
diff --git a/src/vol/vol-info.c b/src/vol/vol-info.c
index a416f0b..fcf0c51 100644
--- a/src/vol/vol-info.c
+++ b/src/vol/vol-info.c
@@ -33,6 +33,7 @@
 #include <sys/time.h>
 #endif
 #include <afs/cmd.h>
+#include <afs/dir.h>
 
 #include <rx/xdr.h>
 #include <afs/afsint.h>
diff --git a/src/vol/vol-salvage.c b/src/vol/vol-salvage.c
index e98b440..270ef1e 100644
--- a/src/vol/vol-salvage.c
+++ b/src/vol/vol-salvage.c
@@ -165,6 +165,7 @@ Vnodes with 0 inode pointers in RW volumes are now deleted.
 #include <afs/osi_inode.h>
 #endif
 #include <afs/cmd.h>
+#include <afs/dir.h>
 #include <afs/afsutil.h>
 #include <afs/fileutil.h>
 #include <afs/procmgmt.h>	/* signal(), kill(), wait(), etc. */
diff --git a/src/volser/vol_split.c b/src/volser/vol_split.c
index 8af67ea..7a26910 100644
--- a/src/volser/vol_split.c
+++ b/src/volser/vol_split.c
@@ -37,6 +37,7 @@
 #include <errno.h>
 #include <sys/stat.h>
 
+#include <afs/dir.h>
 #include <rx/xdr.h>
 #include <afs/afsint.h>
 #include "nfs.h"
diff --git a/src/volser/volmain.c b/src/volser/volmain.c
index b17e783..ab0052c 100644
--- a/src/volser/volmain.c
+++ b/src/volser/volmain.c
@@ -50,6 +50,7 @@
 #include <afs/auth.h>
 #include <afs/cellconfig.h>
 #include <afs/keys.h>
+#include <afs/dir.h>
 #include <ubik.h>
 #include <fcntl.h>
 #include <sys/stat.h>
-- 
1.9.4