From 70f825bcd2de3eab9d0c62079318a215f8728cd6 Mon Sep 17 00:00:00 2001 From: Michael Meffie Date: Thu, 27 Mar 2014 09:24:16 +0100 Subject: [PATCH] viced: disable hot threads Turn off the rx hot threads feature in the file server. This feature was an old optimization intended to reduce context switching, however generally makes performance worse on modern hardware. Performance improvements from disabling hot threads was identified by Simon Wilkinson (YFS) at the European AFS and Kerberos Conference (EAKC) 2014 at CERN. Change-Id: Id3053a61ebdb2d49d2bf36ebe07a35cc07b5d65c Reviewed-on: http://gerrit.openafs.org/10957 Tested-by: BuildBot Reviewed-by: Chas Williams - CONTRACTOR Reviewed-by: D Brashear --- src/viced/viced.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/viced/viced.c b/src/viced/viced.c index b2f3f04..bab39f9 100644 --- a/src/viced/viced.c +++ b/src/viced/viced.c @@ -2055,13 +2055,6 @@ main(int argc, char *argv[]) rx_SetMinProcs(tservice, 2); rx_SetMaxProcs(tservice, 4); - /* - * Enable RX hot threads, which allows the listener thread to trade - * places with an idle thread and moves the context switch from listener - * to worker out of the critical path. - */ - rx_EnableHotThread(); - /* Some rx debugging */ if (rxlog || eventlog) { debugFile = afs_fopen("rx_dbg", "w"); -- 1.9.4