From 86c7369ffadecb0666f75c87469370b66132877f Mon Sep 17 00:00:00 2001 From: Simon Wilkinson Date: Tue, 19 Feb 2013 17:46:04 +0000 Subject: [PATCH] libafscp: Move server lookup inside AFSCP_DEBUG We only use the results of the server lookup when AFSCP_DEBUG is defined, so only bother actually doing the lookup when that is set. Caught by clang-analyzer Change-Id: If79177e9d06817592b0630db7050cf3d40f3ee5f Reviewed-on: http://gerrit.openafs.org/9197 Reviewed-by: Derrick Brashear Tested-by: BuildBot --- src/libafscp/afscp_volume.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libafscp/afscp_volume.c b/src/libafscp/afscp_volume.c index 55421b2..50495d2 100644 --- a/src/libafscp/afscp_volume.c +++ b/src/libafscp/afscp_volume.c @@ -171,8 +171,8 @@ afscp_VolumeByName(struct afscp_cell *cell, const char *vname, } ret->voltype = intype; - server = afscp_ServerByIndex(ret->servers[0]); #ifdef AFSCP_DEBUG + server = afscp_ServerByIndex(ret->servers[0]); if (server != NULL) i.s_addr = server->addrs[0]; else @@ -313,8 +313,8 @@ afscp_VolumeById(struct afscp_cell *cell, afs_uint32 id) break; } ret->voltype = voltype; - server = afscp_ServerByIndex(ret->servers[0]); #ifdef AFSCP_DEBUG + server = afscp_ServerByIndex(ret->servers[0]); if (server) i.s_addr = server->addrs[0]; else -- 1.9.4