From 90199686e6c6cd74d81fa569faa7f68e76d808cd Mon Sep 17 00:00:00 2001 From: Derrick Brashear Date: Tue, 7 Dec 2010 01:13:09 -0500 Subject: [PATCH] afsconf_SuperUser verify identity before use if we didn't get an identity back, don't try to use it. Change-Id: Iff6069b9231c3adc3f74cbf7fff4dffcfc289cd3 Reviewed-on: http://gerrit.openafs.org/3471 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- src/auth/userok.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/auth/userok.c b/src/auth/userok.c index 3be851e..f9e9c93 100644 --- a/src/auth/userok.c +++ b/src/auth/userok.c @@ -795,15 +795,17 @@ afsconf_SuperUser(struct afsconf_dir *adir, struct rx_call *acall, int code; code = afsconf_SuperIdentity(adir, acall, &identity); - if (namep) { - if (identity->kind == RX_ID_KRB4) { - strlcpy(namep, identity->displayName, MAXKTCNAMELEN-1); - } else { - snprintf(namep, MAXKTCNAMELEN-1, "eName: %s", - identity->displayName); + if (code) { + if (namep) { + if (identity->kind == RX_ID_KRB4) { + strlcpy(namep, identity->displayName, MAXKTCNAMELEN-1); + } else { + snprintf(namep, MAXKTCNAMELEN-1, "eName: %s", + identity->displayName); + } } + rx_identity_free(&identity); } - rx_identity_free(&identity); return code; } -- 1.9.4