From 90bc0a7f3108372bfc9408127fea17d37025c9ae Mon Sep 17 00:00:00 2001 From: Jeffrey Altman Date: Sat, 7 Jul 2007 14:36:59 +0000 Subject: [PATCH] windows-give-up-callbacks-20070707 don't try so hard to give up all callbacks. If the server doesn't respond in 10 seconds, too bad! cleanup the server probe code a bit. reorganize the code so that we can avoid unnecessary pointer evaluation. add a missing include file. --- src/WINNT/afsd/cm_callback.c | 2 ++ src/WINNT/afsd/cm_server.c | 11 ++++++----- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/WINNT/afsd/cm_callback.c b/src/WINNT/afsd/cm_callback.c index 6228a8d..e33f618 100644 --- a/src/WINNT/afsd/cm_callback.c +++ b/src/WINNT/afsd/cm_callback.c @@ -1796,7 +1796,9 @@ cm_GiveUpAllCallbacks(cm_server_t *tsp) code = cm_ConnByServer(tsp, cm_rootUserp, &connp); if (code == 0) { rxconnp = cm_GetRxConn(connp); + rx_SetConnDeadTime(rxconnp, 10); code = RXAFS_GiveUpAllCallBacks(rxconnp); + rx_SetConnDeadTime(rxconnp, ConnDeadtimeout); rx_PutConnection(rxconnp); } } diff --git a/src/WINNT/afsd/cm_server.c b/src/WINNT/afsd/cm_server.c index 766306c..4a9b325 100644 --- a/src/WINNT/afsd/cm_server.c +++ b/src/WINNT/afsd/cm_server.c @@ -18,6 +18,7 @@ #include #include "afsd.h" +#include #include #include @@ -83,21 +84,21 @@ cm_PingServer(cm_server_t *tsp) wasDown ? "down" : "up", tsp->capabilities); + rxconnp = cm_GetRxConn(connp); if (wasDown) - rx_SetConnDeadTime(connp->callp, 10); + rx_SetConnDeadTime(rxconnp, 10); if (tsp->type == CM_SERVER_VLDB) { - code = VL_ProbeServer(connp->callp); + code = VL_ProbeServer(rxconnp); } else { /* file server */ - rxconnp = cm_GetRxConn(connp); code = RXAFS_GetCapabilities(rxconnp, &caps); if (code == RXGEN_OPCODE) code = RXAFS_GetTime(rxconnp, &secs, &usecs); - rx_PutConnection(rxconnp); } if (wasDown) - rx_SetConnDeadTime(connp->callp, ConnDeadtimeout); + rx_SetConnDeadTime(rxconnp, ConnDeadtimeout); + rx_PutConnection(rxconnp); cm_PutConn(connp); } /* got an unauthenticated connection to this server */ -- 1.9.4