From 9738c82bd6e5a1c294911d06e3c3e38b70a8caa8 Mon Sep 17 00:00:00 2001 From: Sami Kerola Date: Sun, 23 Jun 2013 22:08:34 +0100 Subject: [PATCH] opr: fix often reported warning $ make CC=cgcc CHECK="smatch -Wsparse-all" 2>&1 | tee debug $ sed -n 's/.*warning: //p' debug | sort | uniq -c | sort -n | tail -1 7218 passing argument 1 of 'opr_AssertionFailed' discards 'const' qualifier from pointer target type [enabled by default] Change-Id: I81c5c1db39b1a08c7dda3caa3d4cdf685186ff5b Address: http://smatch.sourceforge.net/ Reviewed-on: http://gerrit.openafs.org/10019 Tested-by: BuildBot Reviewed-by: Benjamin Kaduk --- src/opr/assert.c | 2 +- src/opr/opr.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/opr/assert.c b/src/opr/assert.c index 7c8998f..e3d3543 100644 --- a/src/opr/assert.c +++ b/src/opr/assert.c @@ -14,7 +14,7 @@ opr_NTAbort(void) #define TIMESTAMP_BUFFER_SIZE 26 /* including the null */ void -opr_AssertionFailed(char *file, int line) +opr_AssertionFailed(const char *file, int line) { char tdate[TIMESTAMP_BUFFER_SIZE]; time_t when; diff --git a/src/opr/opr.h b/src/opr/opr.h index 45e037d..b2cd7d6 100644 --- a/src/opr/opr.h +++ b/src/opr/opr.h @@ -16,7 +16,7 @@ extern void opr_NTAbort(void); # define opr_abort() abort() #endif -extern void opr_AssertionFailed(char *, int) AFS_NORETURN; +extern void opr_AssertionFailed(const char *, int) AFS_NORETURN; extern void opr_AssertFailU(const char *, const char *, int) AFS_NORETURN; /* opr_Assert is designed to work in a similar way to the operating -- 1.9.4