From c0f2c26e9298d12209fbb5e523ea3173202316e5 Mon Sep 17 00:00:00 2001 From: Michael Meffie Date: Fri, 27 Apr 2018 22:59:57 -0400 Subject: [PATCH] vol: check for bad partition names Currently, servers attempt to attach any partition name starting with "/vicep", even partition names which map to out of range partition ids. Examples of such misnamed partitions are "/vicepzz", "/vicep0", and others. The presence of these misnamed partitions cause the server processes to crash on startup, since the out of range partition ids are used as an index. Add a check for the bad partition names in VCheckPartitions to avoid attaching them. Log a warning for such partitions to let the admins know why the partitions are not attached. Change-Id: I553ce6cc8bc751b9ed789312f7efb4e0f737a52e Reviewed-on: https://gerrit.openafs.org/13038 Reviewed-by: Benjamin Kaduk Reviewed-by: Marcio Brito Barbosa Reviewed-by: Andrew Deason Reviewed-by: Mark Vitale Tested-by: Benjamin Kaduk --- src/vol/partition.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/vol/partition.c b/src/vol/partition.c index 272ada3..4bd0344 100644 --- a/src/vol/partition.c +++ b/src/vol/partition.c @@ -289,6 +289,10 @@ VCheckPartition(char *part, char *devname, int logging) if (strncmp(part, VICE_PARTITION_PREFIX, VICE_PREFIX_SIZE)) { return 0; } + if (volutil_GetPartitionID(part) == -1) { + Log("Warning: %s is a bad partition name; ignored.\n", part); + return 0; + } if (afs_stat(part, &status) < 0) { Log("VInitVnodes: Couldn't find file system %s; ignored\n", part); return 0; -- 1.9.4