From dc99144da54d12e8a168c3dfb0255e2a40ba321f Mon Sep 17 00:00:00 2001 From: Mark Vitale Date: Wed, 17 Jul 2019 22:07:45 -0400 Subject: [PATCH] rx: add missing CLEAR_CALL_QUEUE_LOCK to LWP rx_GetCall In all other places where we remove an rx_call from a queue, we also CLEAR_CALL_QUEUE_LOCK. This isn't necessary in the LWP (non-RX_ENABLE_LOCKS) version of rx_GetCall because rx_call does not have member call_queue_lock for LWP. However, for the sake of consistency for future maintainers, add a CLEAR_CALL_QUEUE_LOCK here as well; it is a no-op for LWP. No functional change is incurred by this commit. Change-Id: Ibbb005fa15dd517fc5282574d0d4abd74e937e02 Reviewed-on: https://gerrit.openafs.org/13695 Tested-by: BuildBot Reviewed-by: Andrew Deason Reviewed-by: Benjamin Kaduk --- src/rx/rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rx/rx.c b/src/rx/rx.c index 087b62d..a9225bc 100644 --- a/src/rx/rx.c +++ b/src/rx/rx.c @@ -2273,6 +2273,7 @@ rx_GetCall(int tno, struct rx_service *cur_service, osi_socket * socketp) if (call) { opr_queue_Remove(&call->entry); + CLEAR_CALL_QUEUE_LOCK(call); /* we can't schedule a call if there's no data!!! */ /* send an ack if there's no data, if we're missing the * first packet, or we're missing something between first -- 1.9.4