From fd2cb884e24b5bf48392db4222ee10125014a3ee Mon Sep 17 00:00:00 2001 From: Rainer Toebbicke Date: Fri, 26 Jul 2002 05:58:39 +0000 Subject: [PATCH 1/1] tbutc-uses-not-thread-safe-status-20020725 "The multithreaded butc (src/tbutc/butc) includes bucoord/status.o, which is compiled together with the other bucoord stuff without MT_CFLAGS and hence without AFS_PTHREAD_ENV defined. Alas, it uses ObtainWriteLock and other macros out of lock.h which *are* sensitive to AFS_PTHREAD_ENV. Consequently, butc can hang trying to acquire the statusQueueLock when dumping volumes, in particular if 'backup status' commands are issued frequently. A proper fix would probably be to push some of those macros out of lock.h and make them subroutines in lock.c. A quick fix is ensuring status.c gets recompiled in tbutc/Makefile.in" --- src/tbutc/Makefile.in | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/tbutc/Makefile.in b/src/tbutc/Makefile.in index 585f85b..f2d1485 100644 --- a/src/tbutc/Makefile.in +++ b/src/tbutc/Makefile.in @@ -28,7 +28,7 @@ BUCOORD = ${srcdir}/../bucoord VOLSER = ${srcdir}/../volser BUCOORDOBJS=ubik_db_if.o ../bucoord/volstub.o ../bucoord/dlq.o \ - ../bucoord/status.o ../bucoord/bucoord_errs.o + status.o ../bucoord/bucoord_errs.o VOLSERLIBOBJ=../volser/volint.cs.o vsprocs.o ../volser/vsutils.o \ ../volser/lockprocs.o ../volser/volint.xdr.o ../volser/volerr.o \ @@ -121,6 +121,9 @@ butc_xbsa.o: ${BUTC}/butc_xbsa.c ${BUTC}/butc_xbsa.h ${BUTCINCLS} ubik_db_if.o: ${BUCOORD}/ubik_db_if.c ${CC} ${CFLAGS} -c ${BUCOORD}/ubik_db_if.c +status.o: ${BUCOORD}/status.c + ${CC} ${CFLAGS} -c ${BUCOORD}/status.c + vsprocs.o: ${VOLSER}/vsprocs.c ${CC} ${CFLAGS} -c ${VOLSER}/vsprocs.c -- 1.9.4